Re: [PATCH] xfs/541: _notrun if the file system can't mount

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Jan 28, 2025 at 08:14:48AM +0100, Christoph Hellwig wrote:
> A file system created without an RT section might not be able to mount
> with an rtdev specified if the RT device has a larger LBA size.

Where does the mount failure occur?  The initial mount (where we specify
-o rtdev but sb_rblocks is still zero) should succeed because
xfs_rtmount_init ignores m_rtdev_targp if !rblocks, right?  So it's only
when you get to growfs and we try to read the device that things fail?

--D

> Instead of letting the test fail, _notrun it for that case.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/xfs/541 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/541 b/tests/xfs/541
> index 42bcd95802c5..c8b312fddc92 100755
> --- a/tests/xfs/541
> +++ b/tests/xfs/541
> @@ -26,7 +26,7 @@ _require_scratch
>  
>  # Format scratch fs with no realtime section.
>  SCRATCH_RTDEV="" _scratch_mkfs | _filter_mkfs 2> $tmp.mkfs >> $seqres.full
> -_scratch_mount
> +_try_scratch_mount || _notrun "Can't mount file system"
>  
>  # Zoned file systems don't support rtextsize > 1
>  _require_xfs_scratch_non_zoned
> -- 
> 2.45.2
> 
>