From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
zlang@kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] common: skip tests using LVM when the device is no known
Date: Wed, 29 Jan 2025 06:24:43 +0100 [thread overview]
Message-ID: <20250129052443.GA28621@lst.de> (raw)
In-Reply-To: <20250128193122.GU3557695@frogsfrogsfrogs>
On Tue, Jan 28, 2025 at 11:31:22AM -0800, Darrick J. Wong wrote:
> Should this get turned into a common helper?
> I guess the downside is that pvcreate on my system (Debian 12) will trip
> over any existing disk label and ask if you want to wipe it. If you say
> no then it returns nonzero, and if you say yes then it goes into an
> infinite loop.
>
> You can of course $WIPEFS_PROG -a $bdev but ugghh.
Honestly, for now I just want to avoid the tests failing due to lvm
stupidity. If someone has the time to do something more elaborate
(I don't right now), the proper thing is to stop using lvm and replace
it with something less stupid. That might be direct use of dm,
or simulating failures with null_blk or scsi_debug.
next prev parent reply other threads:[~2025-01-29 5:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 7:16 [PATCH] common: skip tests using LVM when the device is no known Christoph Hellwig
2025-01-28 19:31 ` Darrick J. Wong
2025-01-29 5:24 ` Christoph Hellwig [this message]
2025-01-29 5:40 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250129052443.GA28621@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox