FS/XFS testing framework
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: zlang@kernel.org, djwong@kernel.org
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 1/2] xfs/614: query correct direct I/O alignment
Date: Tue,  4 Feb 2025 14:46:54 +0100	[thread overview]
Message-ID: <20250204134707.2018526-1-hch@lst.de> (raw)

When creating XFS file systems on files, mkfs will query the file system
for the minimum alignment, which can be larger than that of the
underlying device.  Do the same to link the right output file.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/xfs/614 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/614 b/tests/xfs/614
index 0f8952e50b9a..06cc2384f38c 100755
--- a/tests/xfs/614
+++ b/tests/xfs/614
@@ -26,7 +26,7 @@ _require_loop
 $MKFS_XFS_PROG 2>&1 | grep -q concurrency || \
 	_notrun "mkfs does not support concurrency options"
 
-test_dev_lbasize=$(blockdev --getss $TEST_DEV)
+test_dev_lbasize=$($here/src/min_dio_alignment $TEST_DIR $TEST_DEV)
 seqfull=$0
 _link_out_file "lba${test_dev_lbasize}"
 
-- 
2.45.2


             reply	other threads:[~2025-02-04 13:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04 13:46 Christoph Hellwig [this message]
2025-02-04 13:46 ` [PATCH 2/2] xfs/614: remove the _require_loop call Christoph Hellwig
2025-02-04 17:07   ` Darrick J. Wong
2025-02-10 16:21   ` Zorro Lang
2025-02-04 17:12 ` [PATCH 1/2] xfs/614: query correct direct I/O alignment Darrick J. Wong
2025-02-05 15:44   ` Christoph Hellwig
2025-02-05 15:51     ` Darrick J. Wong
2025-02-05 16:07       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250204134707.2018526-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox