From: Jeff Layton <jlayton@kernel.org>
To: fstests@vger.kernel.org
Cc: Jeff Layton <jlayton@kernel.org>
Subject: [PATCH fstests] generic/126: run it inside its own subdirectory
Date: Wed, 19 Feb 2025 11:50:03 -0500 [thread overview]
Message-ID: <20250219-generic126-v1-1-018e4e60c811@kernel.org> (raw)
I had been seeing some failures in generic/126 when running on NFS under
kdevops.
The problem turned out to be that kdevops makes the root of the NFS
export mode 01777 by default (i.e. with the sticky bit set). This causes
some of these permission tests to fail because the open() is called with
the O_CREAT bit set.
Make the outcome of this test not depend on the permissions on
$TEST_DIR. Create a new directory to do these tests in, and clean it up
when done.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
tests/generic/126 | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tests/generic/126 b/tests/generic/126
index 142d2bb97db706bafd2152856ef0993c5c273441..fe0d6db1b6bd85d4942333fdf04d23a63c4052ec 100755
--- a/tests/generic/126
+++ b/tests/generic/126
@@ -23,7 +23,13 @@ _require_chown
QA_FS_PERMS=$here/src/fs_perms
-cd $TEST_DIR
+testdir="$TEST_DIR/generic-126.$$"
+
+mkdir $testdir
+chown 0:0 $testdir
+chmod 0755 $testdir
+cd $testdir
+
cp $here/src/testx ./testx.file
# file_perm owner_uid owner_gid tester_uid tester_gid perm_to_test expected_result pass=1
@@ -46,7 +52,8 @@ $QA_FS_PERMS 200 99 99 200 99 w 1
$QA_FS_PERMS 040 99 99 99 500 r 1
$QA_FS_PERMS 400 99 99 200 99 r 1
-rm -f ./testx.file
+cd /
+rm -rf $testdir
status=0
exit
---
base-commit: 8467552f09e1672a02712653b532a84bd46ea10e
change-id: 20250219-generic126-f81b3022c4b7
Best regards,
--
Jeff Layton <jlayton@kernel.org>
next reply other threads:[~2025-02-19 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 16:50 Jeff Layton [this message]
2025-02-19 17:18 ` [PATCH fstests] generic/126: run it inside its own subdirectory Darrick J. Wong
2025-02-19 21:00 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219-generic126-v1-1-018e4e60c811@kernel.org \
--to=jlayton@kernel.org \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox