From: Christoph Hellwig <hch@lst.de>
To: zlang@kernel.org
Cc: djwong@kernel.org, hans.holmberg@wdc.com,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH] common: skip zoned devices in _require_populate_commands
Date: Mon, 12 May 2025 15:18:19 +0200 [thread overview]
Message-ID: <20250512131819.629435-1-hch@lst.de> (raw)
mdrestore doesn't work on zoned device, so skip tests using to
pre-populate a file system image.
This was previously papered over by requiring fallocate, which got
removed in commit eff1baf42a79 ("common/populate: drop fallocate
mode 0 requirement").
Note that the populate helpers for placement on the data device anyway,
so they never exercised the rt device. Maybe we should skip them for
all rt device setups and not just zoned ones to save some execution
time?
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
common/populate | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/common/populate b/common/populate
index 50dc75d35259..6190eac7ad83 100644
--- a/common/populate
+++ b/common/populate
@@ -20,6 +20,10 @@ _require_populate_commands() {
_require_command "$XFS_DB_PROG" "xfs_db"
_require_command "$WIPEFS_PROG" "wipefs"
_require_command "$XFS_MDRESTORE_PROG" "xfs_mdrestore"
+
+ # mdrestore can't restore to zoned devices
+ _require_non_zoned_device $SCRATCH_DEV
+ _require_non_zoned_device $SCRATCH_RTDEV
;;
ext*)
_require_command "$DUMPE2FS_PROG" "dumpe2fs"
--
2.47.2
next reply other threads:[~2025-05-12 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 13:18 Christoph Hellwig [this message]
2025-05-12 15:08 ` [PATCH] common: skip zoned devices in _require_populate_commands Darrick J. Wong
2025-05-12 15:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512131819.629435-1-hch@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox