Re: [PATCH] xfs/603: add _require_scrub

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Jun 11, 2025 at 02:50:11PM +0200, Carlos Maiolino wrote:
> On Tue, Jun 10, 2025 at 07:46:00AM -0700, Darrick J. Wong wrote:
> > On Tue, Jun 10, 2025 at 05:11:34PM +0800, Ma Xinjian wrote:
> > > From: Xinjian Ma <maxj.fnst@fujitsu.com>
> > >
> > > This test uses xfs_scrub which is an EXPERIMENTAL and unstable feature.
> > > Add _require_scrub to check if the system supports it.
> > >
> > > Signed-off-by: Xinjian Ma <maxj.fnst@fujitsu.com>
> > 
> > Oops, thanks for the correction.
> > Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> 
> Experimental has meen removed from scrub in 6.16, is this still needed?

Yes, _require_scrub checks that the userspace driver program exists.

--D

> > 
> > --D
> > 
> > > ---
> > >  tests/xfs/603 | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tests/xfs/603 b/tests/xfs/603
> > > index 04122b55..d6058a3e 100755
> > > --- a/tests/xfs/603
> > > +++ b/tests/xfs/603
> > > @@ -20,6 +20,7 @@ _require_xfs_db_command iunlink
> > >  # until after the directory repair code was merged
> > >  _require_xfs_io_command repair -R directory
> > >  _require_scratch_nocheck	# repair doesn't like single-AG fs
> > > +_require_scrub
> > >
> > >  # From the AGI definition
> > >  XFS_AGI_UNLINKED_BUCKETS=64
> > > --
> > > 2.49.0
> > >
> > >
> > 
>