[PATCH 0/3] Update to account for attr2 and ikeep removal

[PATCH 0/3] Update to account for attr2 and ikeep removal

[cem]

From: Carlos Maiolino <cem@kernel.org>

Linux 6.17 removes attr2 and ikeep mount options, which have been
deprecated for a long time.

There are 3 specific tests that fails now due to the abscence of such
mount options:

Both xfs/513 and xfs/613 tests several mount options, so this series
only update both tests.

xfs/539 on the other hand has been written specifically for such
options, so it is pointless to keep this for 6.17 and above.


Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>

Carlos Maiolino (3):
  xfs/513: remove attr2 and ikeep tests
  xfs/613: remove attr2 tests
  xfs/539: Remove test for good

 tests/xfs/513     | 11 --------
 tests/xfs/513.out |  7 -----
 tests/xfs/539     | 72 -----------------------------------------------
 tests/xfs/539.out |  2 --
 tests/xfs/613     |  6 ----
 tests/xfs/613.out |  4 ---
 6 files changed, 102 deletions(-)
 delete mode 100755 tests/xfs/539
 delete mode 100644 tests/xfs/539.out

-- 
2.51.0

[PATCH 1/3] xfs/513: remove attr2 and ikeep tests

[cem]

From: Carlos Maiolino <cem@kernel.org>

Linux kernel commit b9a176e54162 removes several deprecated options
from XFS, causing this test to fail.

Giving the options have been removed from Linux for good, just stop
testing these options here.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 tests/xfs/513     | 11 -----------
 tests/xfs/513.out |  7 -------
 2 files changed, 18 deletions(-)

diff --git a/tests/xfs/513 b/tests/xfs/513
index d3be3ced68a1..7dbd2626d9e2 100755
--- a/tests/xfs/513
+++ b/tests/xfs/513
@@ -182,12 +182,6 @@ do_test "-o allocsize=1048576k" pass "allocsize=1048576k" "true"
 do_test "-o allocsize=$((dbsize / 2))" fail
 do_test "-o allocsize=2g" fail
 
-# Test attr2
-do_mkfs -m crc=1
-do_test "" pass "attr2" "true"
-do_test "-o attr2" pass "attr2" "true"
-do_test "-o noattr2" fail
-
 # Test discard
 do_mkfs
 do_test "" pass "discard" "false"
@@ -205,11 +199,6 @@ do_test "-o sysvgroups" pass "grpid" "false"
 do_test "" pass "filestreams" "false"
 do_test "-o filestreams" pass "filestreams" "true"
 
-# Test ikeep
-do_test "" pass "ikeep" "false"
-do_test "-o ikeep" pass "ikeep" "true"
-do_test "-o noikeep" pass "ikeep" "false"
-
 # Test inode32|inode64
 do_test "" pass "inode64" "true"
 do_test "-o inode32" pass "inode32" "true"
diff --git a/tests/xfs/513.out b/tests/xfs/513.out
index 39945907140b..127f1681f979 100644
--- a/tests/xfs/513.out
+++ b/tests/xfs/513.out
@@ -9,10 +9,6 @@ TEST: "-o allocsize=PAGESIZE" "pass" "allocsize=PAGESIZE" "true"
 TEST: "-o allocsize=1048576k" "pass" "allocsize=1048576k" "true"
 TEST: "-o allocsize=2048" "fail"
 TEST: "-o allocsize=2g" "fail"
-FORMAT: -m crc=1
-TEST: "" "pass" "attr2" "true"
-TEST: "-o attr2" "pass" "attr2" "true"
-TEST: "-o noattr2" "fail"
 FORMAT: 
 TEST: "" "pass" "discard" "false"
 TEST: "-o discard" "pass" "discard" "true"
@@ -24,9 +20,6 @@ TEST: "-o nogrpid" "pass" "grpid" "false"
 TEST: "-o sysvgroups" "pass" "grpid" "false"
 TEST: "" "pass" "filestreams" "false"
 TEST: "-o filestreams" "pass" "filestreams" "true"
-TEST: "" "pass" "ikeep" "false"
-TEST: "-o ikeep" "pass" "ikeep" "true"
-TEST: "-o noikeep" "pass" "ikeep" "false"
 TEST: "" "pass" "inode64" "true"
 TEST: "-o inode32" "pass" "inode32" "true"
 TEST: "-o inode64" "pass" "inode64" "true"
-- 
2.51.0

Re: [PATCH 1/3] xfs/513: remove attr2 and ikeep tests

[Zorro Lang]

On Thu, Sep 25, 2025 at 11:29:24AM +0200, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> Linux kernel commit b9a176e54162 removes several deprecated options
                      ^^^^^^^^^^^^

I think this's a commit id of xfs-linux, not mainline linux. Anyway,
this patch makes sense to me.

Reviewed-by: Zorro Lang <zlang@redhat.com>



> from XFS, causing this test to fail.
> 
> Giving the options have been removed from Linux for good, just stop
> testing these options here.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
>  tests/xfs/513     | 11 -----------
>  tests/xfs/513.out |  7 -------
>  2 files changed, 18 deletions(-)
> 
> diff --git a/tests/xfs/513 b/tests/xfs/513
> index d3be3ced68a1..7dbd2626d9e2 100755
> --- a/tests/xfs/513
> +++ b/tests/xfs/513
> @@ -182,12 +182,6 @@ do_test "-o allocsize=1048576k" pass "allocsize=1048576k" "true"
>  do_test "-o allocsize=$((dbsize / 2))" fail
>  do_test "-o allocsize=2g" fail
>  
> -# Test attr2
> -do_mkfs -m crc=1
> -do_test "" pass "attr2" "true"
> -do_test "-o attr2" pass "attr2" "true"
> -do_test "-o noattr2" fail
> -
>  # Test discard
>  do_mkfs
>  do_test "" pass "discard" "false"
> @@ -205,11 +199,6 @@ do_test "-o sysvgroups" pass "grpid" "false"
>  do_test "" pass "filestreams" "false"
>  do_test "-o filestreams" pass "filestreams" "true"
>  
> -# Test ikeep
> -do_test "" pass "ikeep" "false"
> -do_test "-o ikeep" pass "ikeep" "true"
> -do_test "-o noikeep" pass "ikeep" "false"
> -
>  # Test inode32|inode64
>  do_test "" pass "inode64" "true"
>  do_test "-o inode32" pass "inode32" "true"
> diff --git a/tests/xfs/513.out b/tests/xfs/513.out
> index 39945907140b..127f1681f979 100644
> --- a/tests/xfs/513.out
> +++ b/tests/xfs/513.out
> @@ -9,10 +9,6 @@ TEST: "-o allocsize=PAGESIZE" "pass" "allocsize=PAGESIZE" "true"
>  TEST: "-o allocsize=1048576k" "pass" "allocsize=1048576k" "true"
>  TEST: "-o allocsize=2048" "fail"
>  TEST: "-o allocsize=2g" "fail"
> -FORMAT: -m crc=1
> -TEST: "" "pass" "attr2" "true"
> -TEST: "-o attr2" "pass" "attr2" "true"
> -TEST: "-o noattr2" "fail"
>  FORMAT: 
>  TEST: "" "pass" "discard" "false"
>  TEST: "-o discard" "pass" "discard" "true"
> @@ -24,9 +20,6 @@ TEST: "-o nogrpid" "pass" "grpid" "false"
>  TEST: "-o sysvgroups" "pass" "grpid" "false"
>  TEST: "" "pass" "filestreams" "false"
>  TEST: "-o filestreams" "pass" "filestreams" "true"
> -TEST: "" "pass" "ikeep" "false"
> -TEST: "-o ikeep" "pass" "ikeep" "true"
> -TEST: "-o noikeep" "pass" "ikeep" "false"
>  TEST: "" "pass" "inode64" "true"
>  TEST: "-o inode32" "pass" "inode32" "true"
>  TEST: "-o inode64" "pass" "inode64" "true"
> -- 
> 2.51.0
> 

Re: [PATCH 1/3] xfs/513: remove attr2 and ikeep tests

[Carlos Maiolino]

On Fri, Sep 26, 2025 at 11:32:37PM +0800, Zorro Lang wrote:
> On Thu, Sep 25, 2025 at 11:29:24AM +0200, cem@kernel.org wrote:
> > From: Carlos Maiolino <cem@kernel.org>
> >
> > Linux kernel commit b9a176e54162 removes several deprecated options
>                       ^^^^^^^^^^^^
> 
> I think this's a commit id of xfs-linux, not mainline linux. Anyway,
> this patch makes sense to me.

Yes, because these patches are not in Linus's tree yet, I'll send them
on 6.18 merge window. I just thought it would make sense to send them to
fstests ASAP.


> 
> Reviewed-by: Zorro Lang <zlang@redhat.com>
> 
> 
> 
> > from XFS, causing this test to fail.
> >
> > Giving the options have been removed from Linux for good, just stop
> > testing these options here.
> >
> > Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> > ---
> >  tests/xfs/513     | 11 -----------
> >  tests/xfs/513.out |  7 -------
> >  2 files changed, 18 deletions(-)
> >
> > diff --git a/tests/xfs/513 b/tests/xfs/513
> > index d3be3ced68a1..7dbd2626d9e2 100755
> > --- a/tests/xfs/513
> > +++ b/tests/xfs/513
> > @@ -182,12 +182,6 @@ do_test "-o allocsize=1048576k" pass "allocsize=1048576k" "true"
> >  do_test "-o allocsize=$((dbsize / 2))" fail
> >  do_test "-o allocsize=2g" fail
> >
> > -# Test attr2
> > -do_mkfs -m crc=1
> > -do_test "" pass "attr2" "true"
> > -do_test "-o attr2" pass "attr2" "true"
> > -do_test "-o noattr2" fail
> > -
> >  # Test discard
> >  do_mkfs
> >  do_test "" pass "discard" "false"
> > @@ -205,11 +199,6 @@ do_test "-o sysvgroups" pass "grpid" "false"
> >  do_test "" pass "filestreams" "false"
> >  do_test "-o filestreams" pass "filestreams" "true"
> >
> > -# Test ikeep
> > -do_test "" pass "ikeep" "false"
> > -do_test "-o ikeep" pass "ikeep" "true"
> > -do_test "-o noikeep" pass "ikeep" "false"
> > -
> >  # Test inode32|inode64
> >  do_test "" pass "inode64" "true"
> >  do_test "-o inode32" pass "inode32" "true"
> > diff --git a/tests/xfs/513.out b/tests/xfs/513.out
> > index 39945907140b..127f1681f979 100644
> > --- a/tests/xfs/513.out
> > +++ b/tests/xfs/513.out
> > @@ -9,10 +9,6 @@ TEST: "-o allocsize=PAGESIZE" "pass" "allocsize=PAGESIZE" "true"
> >  TEST: "-o allocsize=1048576k" "pass" "allocsize=1048576k" "true"
> >  TEST: "-o allocsize=2048" "fail"
> >  TEST: "-o allocsize=2g" "fail"
> > -FORMAT: -m crc=1
> > -TEST: "" "pass" "attr2" "true"
> > -TEST: "-o attr2" "pass" "attr2" "true"
> > -TEST: "-o noattr2" "fail"
> >  FORMAT:
> >  TEST: "" "pass" "discard" "false"
> >  TEST: "-o discard" "pass" "discard" "true"
> > @@ -24,9 +20,6 @@ TEST: "-o nogrpid" "pass" "grpid" "false"
> >  TEST: "-o sysvgroups" "pass" "grpid" "false"
> >  TEST: "" "pass" "filestreams" "false"
> >  TEST: "-o filestreams" "pass" "filestreams" "true"
> > -TEST: "" "pass" "ikeep" "false"
> > -TEST: "-o ikeep" "pass" "ikeep" "true"
> > -TEST: "-o noikeep" "pass" "ikeep" "false"
> >  TEST: "" "pass" "inode64" "true"
> >  TEST: "-o inode32" "pass" "inode32" "true"
> >  TEST: "-o inode64" "pass" "inode64" "true"
> > --
> > 2.51.0
> >
> 

Re: [PATCH 1/3] xfs/513: remove attr2 and ikeep tests

[Zorro Lang]

On Sat, Sep 27, 2025 at 09:29:50AM +0200, Carlos Maiolino wrote:
> On Fri, Sep 26, 2025 at 11:32:37PM +0800, Zorro Lang wrote:
> > On Thu, Sep 25, 2025 at 11:29:24AM +0200, cem@kernel.org wrote:
> > > From: Carlos Maiolino <cem@kernel.org>
> > >
> > > Linux kernel commit b9a176e54162 removes several deprecated options
> >                       ^^^^^^^^^^^^
> > 
> > I think this's a commit id of xfs-linux, not mainline linux. Anyway,
> > this patch makes sense to me.
> 
> Yes, because these patches are not in Linus's tree yet, I'll send them
> on 6.18 merge window. I just thought it would make sense to send them to
> fstests ASAP.

Sure, it's good to me to merge this into fstests at first, as xfs list already
acked and merged :)

> 
> 
> > 
> > Reviewed-by: Zorro Lang <zlang@redhat.com>
> > 
> > 
> > 
> > > from XFS, causing this test to fail.
> > >
> > > Giving the options have been removed from Linux for good, just stop
> > > testing these options here.
> > >
> > > Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> > > ---
> > >  tests/xfs/513     | 11 -----------
> > >  tests/xfs/513.out |  7 -------
> > >  2 files changed, 18 deletions(-)
> > >
> > > diff --git a/tests/xfs/513 b/tests/xfs/513
> > > index d3be3ced68a1..7dbd2626d9e2 100755
> > > --- a/tests/xfs/513
> > > +++ b/tests/xfs/513
> > > @@ -182,12 +182,6 @@ do_test "-o allocsize=1048576k" pass "allocsize=1048576k" "true"
> > >  do_test "-o allocsize=$((dbsize / 2))" fail
> > >  do_test "-o allocsize=2g" fail
> > >
> > > -# Test attr2
> > > -do_mkfs -m crc=1
> > > -do_test "" pass "attr2" "true"
> > > -do_test "-o attr2" pass "attr2" "true"
> > > -do_test "-o noattr2" fail
> > > -
> > >  # Test discard
> > >  do_mkfs
> > >  do_test "" pass "discard" "false"
> > > @@ -205,11 +199,6 @@ do_test "-o sysvgroups" pass "grpid" "false"
> > >  do_test "" pass "filestreams" "false"
> > >  do_test "-o filestreams" pass "filestreams" "true"
> > >
> > > -# Test ikeep
> > > -do_test "" pass "ikeep" "false"
> > > -do_test "-o ikeep" pass "ikeep" "true"
> > > -do_test "-o noikeep" pass "ikeep" "false"
> > > -
> > >  # Test inode32|inode64
> > >  do_test "" pass "inode64" "true"
> > >  do_test "-o inode32" pass "inode32" "true"
> > > diff --git a/tests/xfs/513.out b/tests/xfs/513.out
> > > index 39945907140b..127f1681f979 100644
> > > --- a/tests/xfs/513.out
> > > +++ b/tests/xfs/513.out
> > > @@ -9,10 +9,6 @@ TEST: "-o allocsize=PAGESIZE" "pass" "allocsize=PAGESIZE" "true"
> > >  TEST: "-o allocsize=1048576k" "pass" "allocsize=1048576k" "true"
> > >  TEST: "-o allocsize=2048" "fail"
> > >  TEST: "-o allocsize=2g" "fail"
> > > -FORMAT: -m crc=1
> > > -TEST: "" "pass" "attr2" "true"
> > > -TEST: "-o attr2" "pass" "attr2" "true"
> > > -TEST: "-o noattr2" "fail"
> > >  FORMAT:
> > >  TEST: "" "pass" "discard" "false"
> > >  TEST: "-o discard" "pass" "discard" "true"
> > > @@ -24,9 +20,6 @@ TEST: "-o nogrpid" "pass" "grpid" "false"
> > >  TEST: "-o sysvgroups" "pass" "grpid" "false"
> > >  TEST: "" "pass" "filestreams" "false"
> > >  TEST: "-o filestreams" "pass" "filestreams" "true"
> > > -TEST: "" "pass" "ikeep" "false"
> > > -TEST: "-o ikeep" "pass" "ikeep" "true"
> > > -TEST: "-o noikeep" "pass" "ikeep" "false"
> > >  TEST: "" "pass" "inode64" "true"
> > >  TEST: "-o inode32" "pass" "inode32" "true"
> > >  TEST: "-o inode64" "pass" "inode64" "true"
> > > --
> > > 2.51.0
> > >
> > 
> 

[PATCH 2/3] xfs/613: remove attr2 tests

[cem]

From: Carlos Maiolino <cem@kernel.org>

Linux kernel commit b9a176e54162 removes several deprecated options
from XFS, causing this test to fail.

Giving the options have been removed from Linux for good, just stop
testing these options here.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 tests/xfs/613     | 6 ------
 tests/xfs/613.out | 4 ----
 2 files changed, 10 deletions(-)

diff --git a/tests/xfs/613 b/tests/xfs/613
index 9b27a7c1f2c2..c26a4424f486 100755
--- a/tests/xfs/613
+++ b/tests/xfs/613
@@ -163,12 +163,6 @@ do_test()
 }
 
 echo "** start xfs mount testing ..."
-# Test attr2
-do_mkfs -m crc=0
-do_test "" pass "attr2" "true"
-do_test "-o attr2" pass "attr2" "true"
-do_test "-o noattr2" pass "attr2" "false"
-
 # Test logbsize=value.
 do_mkfs -m crc=0 -l version=1
 # New kernel (refer to 4f62282a3696 xfs: cleanup xlog_get_iclog_buffer_size)
diff --git a/tests/xfs/613.out b/tests/xfs/613.out
index 2a693c53c584..add534bd63a9 100644
--- a/tests/xfs/613.out
+++ b/tests/xfs/613.out
@@ -2,10 +2,6 @@ QA output created by 613
 ** create loop device
 ** create loop mount point
 ** start xfs mount testing ...
-FORMAT: -m crc=0
-TEST: "" "pass" "attr2" "true"
-TEST: "-o attr2" "pass" "attr2" "true"
-TEST: "-o noattr2" "pass" "attr2" "false"
 FORMAT: -m crc=0 -l version=1
 TEST: "-o logbsize=16384" "pass" "logbsize=16k" "true"
 TEST: "-o logbsize=16k" "pass" "logbsize=16k" "true"
-- 
2.51.0

Re: [PATCH 2/3] xfs/613: remove attr2 tests

[Zorro Lang]

On Thu, Sep 25, 2025 at 11:29:25AM +0200, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> Linux kernel commit b9a176e54162 removes several deprecated options
> from XFS, causing this test to fail.
> 
> Giving the options have been removed from Linux for good, just stop
> testing these options here.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
>  tests/xfs/613     | 6 ------
>  tests/xfs/613.out | 4 ----
>  2 files changed, 10 deletions(-)
> 
> diff --git a/tests/xfs/613 b/tests/xfs/613
> index 9b27a7c1f2c2..c26a4424f486 100755
> --- a/tests/xfs/613
> +++ b/tests/xfs/613
> @@ -163,12 +163,6 @@ do_test()
>  }
>  
>  echo "** start xfs mount testing ..."
> -# Test attr2
> -do_mkfs -m crc=0

OK, as attr2 option is removed earlier than V4 xfs, so the _require_xfs_nocrc
is helpless for this case. Thanks for fixing this,

Reviewed-by: Zorro Lang <zlang@redhat.com>

> -do_test "" pass "attr2" "true"
> -do_test "-o attr2" pass "attr2" "true"
> -do_test "-o noattr2" pass "attr2" "false"
> -
>  # Test logbsize=value.
>  do_mkfs -m crc=0 -l version=1
>  # New kernel (refer to 4f62282a3696 xfs: cleanup xlog_get_iclog_buffer_size)
> diff --git a/tests/xfs/613.out b/tests/xfs/613.out
> index 2a693c53c584..add534bd63a9 100644
> --- a/tests/xfs/613.out
> +++ b/tests/xfs/613.out
> @@ -2,10 +2,6 @@ QA output created by 613
>  ** create loop device
>  ** create loop mount point
>  ** start xfs mount testing ...
> -FORMAT: -m crc=0
> -TEST: "" "pass" "attr2" "true"
> -TEST: "-o attr2" "pass" "attr2" "true"
> -TEST: "-o noattr2" "pass" "attr2" "false"
>  FORMAT: -m crc=0 -l version=1
>  TEST: "-o logbsize=16384" "pass" "logbsize=16k" "true"
>  TEST: "-o logbsize=16k" "pass" "logbsize=16k" "true"
> -- 
> 2.51.0
> 

[PATCH 3/3] xfs/539: Remove test for good

[cem]

From: Carlos Maiolino <cem@kernel.org>

This check deprecation warnings are not being printed during remount for
both attr2 and ikeep mount options.

Both options are now gone in 6.17, so this test not only is pointless
from 6.17 and above, but will always fail due the lack of these options.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 tests/xfs/539     | 72 -----------------------------------------------
 tests/xfs/539.out |  2 --
 2 files changed, 74 deletions(-)
 delete mode 100755 tests/xfs/539
 delete mode 100644 tests/xfs/539.out

diff --git a/tests/xfs/539 b/tests/xfs/539
deleted file mode 100755
index 5098be4a9351..000000000000
--- a/tests/xfs/539
+++ /dev/null
@@ -1,72 +0,0 @@
-#! /bin/bash
-# SPDX-License-Identifier: GPL-2.0
-# Copyright (c) 2020 Red Hat, Inc.. All Rights Reserved.
-#
-# FS QA Test 539
-#
-# https://bugzilla.kernel.org/show_bug.cgi?id=211605
-# Verify that the warnings are not printed on remount if the mount option has
-# the same value as during the mount
-#
-# Regression test for commit:
-# 92cf7d36384b xfs: Skip repetitive warnings about mount options
-
-. ./common/preamble
-_begin_fstest auto quick mount
-
-# Import common functions.
-
-_fixed_by_kernel_commit 92cf7d36384b \
-	"xfs: Skip repetitive warnings about mount options"
-
-_require_check_dmesg
-_require_scratch
-
-log_tag()
-{
-	echo "fstests $seqnum [tag]" > /dev/kmsg
-}
-
-dmesg_since_test_tag()
-{
-	dmesg | tac | sed -ne "0,\#fstests $seqnum \[tag\]#p" | \
-		tac
-}
-
-check_dmesg_for_since_tag()
-{
-	dmesg_since_test_tag | grep -E -q "$1"
-}
-
-echo "Silence is golden."
-
-# Skip old kernels that did not print the warning yet
-log_tag
-_scratch_mkfs > $seqres.full 2>&1
-_scratch_mount -o attr2
-_scratch_unmount
-check_dmesg_for_since_tag "XFS: attr2 mount option is deprecated" || \
-	_notrun "Deprecation warning are not printed at all."
-
-# Test mount with default options (attr2 and noikeep) and remount with
-# 2 groups of options
-# 1) the defaults (attr2, noikeep)
-# 2) non defaults (noattr2, ikeep)
-_scratch_mount
-for VAR in {attr2,noikeep}; do
-	log_tag
-	_scratch_remount $VAR
-	check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated." && \
-		echo "Should not be able to find deprecation warning for $VAR"
-done
-for VAR in {noattr2,ikeep}; do
-	log_tag
-	_scratch_remount $VAR >> $seqres.full 2>&1
-	check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated" || \
-		echo "Could not find deprecation warning for $VAR"
-done
-_scratch_unmount
-
-# success, all done
-status=0
-exit
diff --git a/tests/xfs/539.out b/tests/xfs/539.out
deleted file mode 100644
index 038993426333..000000000000
--- a/tests/xfs/539.out
+++ /dev/null
@@ -1,2 +0,0 @@
-QA output created by 539
-Silence is golden.
-- 
2.51.0

Re: [PATCH 3/3] xfs/539: Remove test for good

[Zorro Lang]

On Thu, Sep 25, 2025 at 11:29:26AM +0200, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> This check deprecation warnings are not being printed during remount for
> both attr2 and ikeep mount options.
> 
> Both options are now gone in 6.17, so this test not only is pointless
> from 6.17 and above, but will always fail due the lack of these options.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
>  tests/xfs/539     | 72 -----------------------------------------------
>  tests/xfs/539.out |  2 --
>  2 files changed, 74 deletions(-)
>  delete mode 100755 tests/xfs/539
>  delete mode 100644 tests/xfs/539.out
> 
> diff --git a/tests/xfs/539 b/tests/xfs/539
> deleted file mode 100755
> index 5098be4a9351..000000000000
> --- a/tests/xfs/539
> +++ /dev/null
> @@ -1,72 +0,0 @@
> -#! /bin/bash
> -# SPDX-License-Identifier: GPL-2.0
> -# Copyright (c) 2020 Red Hat, Inc.. All Rights Reserved.
> -#
> -# FS QA Test 539
> -#
> -# https://bugzilla.kernel.org/show_bug.cgi?id=211605

As the "attr2" and "ikeep" have been removed, so we don't need this bug
coverage either. I'm good to remove this.

Reviewed-by: Zorro Lang <zlang@redhat.com>

> -# Verify that the warnings are not printed on remount if the mount option has
> -# the same value as during the mount
> -#
> -# Regression test for commit:
> -# 92cf7d36384b xfs: Skip repetitive warnings about mount options
> -
> -. ./common/preamble
> -_begin_fstest auto quick mount
> -
> -# Import common functions.
> -
> -_fixed_by_kernel_commit 92cf7d36384b \
> -	"xfs: Skip repetitive warnings about mount options"
> -
> -_require_check_dmesg
> -_require_scratch
> -
> -log_tag()
> -{
> -	echo "fstests $seqnum [tag]" > /dev/kmsg
> -}
> -
> -dmesg_since_test_tag()
> -{
> -	dmesg | tac | sed -ne "0,\#fstests $seqnum \[tag\]#p" | \
> -		tac
> -}
> -
> -check_dmesg_for_since_tag()
> -{
> -	dmesg_since_test_tag | grep -E -q "$1"
> -}
> -
> -echo "Silence is golden."
> -
> -# Skip old kernels that did not print the warning yet
> -log_tag
> -_scratch_mkfs > $seqres.full 2>&1
> -_scratch_mount -o attr2
> -_scratch_unmount
> -check_dmesg_for_since_tag "XFS: attr2 mount option is deprecated" || \
> -	_notrun "Deprecation warning are not printed at all."
> -
> -# Test mount with default options (attr2 and noikeep) and remount with
> -# 2 groups of options
> -# 1) the defaults (attr2, noikeep)
> -# 2) non defaults (noattr2, ikeep)
> -_scratch_mount
> -for VAR in {attr2,noikeep}; do
> -	log_tag
> -	_scratch_remount $VAR
> -	check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated." && \
> -		echo "Should not be able to find deprecation warning for $VAR"
> -done
> -for VAR in {noattr2,ikeep}; do
> -	log_tag
> -	_scratch_remount $VAR >> $seqres.full 2>&1
> -	check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated" || \
> -		echo "Could not find deprecation warning for $VAR"
> -done
> -_scratch_unmount
> -
> -# success, all done
> -status=0
> -exit
> diff --git a/tests/xfs/539.out b/tests/xfs/539.out
> deleted file mode 100644
> index 038993426333..000000000000
> --- a/tests/xfs/539.out
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -QA output created by 539
> -Silence is golden.
> -- 
> 2.51.0
>