public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: cem@kernel.org
To: zlang@redhat.com
Cc: djwong@kernel.org, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 3/3] xfs/539: Remove test for good
Date: Thu, 25 Sep 2025 11:29:26 +0200	[thread overview]
Message-ID: <20250925093005.198090-4-cem@kernel.org> (raw)
In-Reply-To: <20250925093005.198090-1-cem@kernel.org>

From: Carlos Maiolino <cem@kernel.org>

This check deprecation warnings are not being printed during remount for
both attr2 and ikeep mount options.

Both options are now gone in 6.17, so this test not only is pointless
from 6.17 and above, but will always fail due the lack of these options.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 tests/xfs/539     | 72 -----------------------------------------------
 tests/xfs/539.out |  2 --
 2 files changed, 74 deletions(-)
 delete mode 100755 tests/xfs/539
 delete mode 100644 tests/xfs/539.out

diff --git a/tests/xfs/539 b/tests/xfs/539
deleted file mode 100755
index 5098be4a9351..000000000000
--- a/tests/xfs/539
+++ /dev/null
@@ -1,72 +0,0 @@
-#! /bin/bash
-# SPDX-License-Identifier: GPL-2.0
-# Copyright (c) 2020 Red Hat, Inc.. All Rights Reserved.
-#
-# FS QA Test 539
-#
-# https://bugzilla.kernel.org/show_bug.cgi?id=211605
-# Verify that the warnings are not printed on remount if the mount option has
-# the same value as during the mount
-#
-# Regression test for commit:
-# 92cf7d36384b xfs: Skip repetitive warnings about mount options
-
-. ./common/preamble
-_begin_fstest auto quick mount
-
-# Import common functions.
-
-_fixed_by_kernel_commit 92cf7d36384b \
-	"xfs: Skip repetitive warnings about mount options"
-
-_require_check_dmesg
-_require_scratch
-
-log_tag()
-{
-	echo "fstests $seqnum [tag]" > /dev/kmsg
-}
-
-dmesg_since_test_tag()
-{
-	dmesg | tac | sed -ne "0,\#fstests $seqnum \[tag\]#p" | \
-		tac
-}
-
-check_dmesg_for_since_tag()
-{
-	dmesg_since_test_tag | grep -E -q "$1"
-}
-
-echo "Silence is golden."
-
-# Skip old kernels that did not print the warning yet
-log_tag
-_scratch_mkfs > $seqres.full 2>&1
-_scratch_mount -o attr2
-_scratch_unmount
-check_dmesg_for_since_tag "XFS: attr2 mount option is deprecated" || \
-	_notrun "Deprecation warning are not printed at all."
-
-# Test mount with default options (attr2 and noikeep) and remount with
-# 2 groups of options
-# 1) the defaults (attr2, noikeep)
-# 2) non defaults (noattr2, ikeep)
-_scratch_mount
-for VAR in {attr2,noikeep}; do
-	log_tag
-	_scratch_remount $VAR
-	check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated." && \
-		echo "Should not be able to find deprecation warning for $VAR"
-done
-for VAR in {noattr2,ikeep}; do
-	log_tag
-	_scratch_remount $VAR >> $seqres.full 2>&1
-	check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated" || \
-		echo "Could not find deprecation warning for $VAR"
-done
-_scratch_unmount
-
-# success, all done
-status=0
-exit
diff --git a/tests/xfs/539.out b/tests/xfs/539.out
deleted file mode 100644
index 038993426333..000000000000
--- a/tests/xfs/539.out
+++ /dev/null
@@ -1,2 +0,0 @@
-QA output created by 539
-Silence is golden.
-- 
2.51.0


  parent reply	other threads:[~2025-09-25  9:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25  9:29 [PATCH 0/3] Update to account for attr2 and ikeep removal cem
2025-09-25  9:29 ` [PATCH 1/3] xfs/513: remove attr2 and ikeep tests cem
2025-09-26 15:32   ` Zorro Lang
2025-09-27  7:29     ` Carlos Maiolino
2025-09-27 13:42       ` Zorro Lang
2025-09-25  9:29 ` [PATCH 2/3] xfs/613: remove attr2 tests cem
2025-09-26 15:35   ` Zorro Lang
2025-09-25  9:29 ` cem [this message]
2025-09-26 15:37   ` [PATCH 3/3] xfs/539: Remove test for good Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250925093005.198090-4-cem@kernel.org \
    --to=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox