From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D81811509A0 for ; Sun, 12 Oct 2025 19:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760299065; cv=none; b=Vqp5jJicZfSRlp5XgjF8Ahv+YjU4pluNBQn7M08bPWF+p0jVxUuKi+TfwlcPtSlqJZSzibuZqR0G/ouRmXdyrKVuXKl6UyNv3McdIW2hMQeE3QGJ5mPLREVsozfQlFfxFCes1ZfVk96rXPLxFeeGyifDigDYS3n7Fgn0k5Gc4IM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760299065; c=relaxed/simple; bh=gCLk5c6ldi0yie6zeA0N3pqyyIaQvO6v6fdlz4qoT0s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LZAinRZBW1OUUYnLCStIVOvxN485KMwTM6YI6EFKFLwD67I0Q4DYgMbxdciahOZeJxFxcyesy9or42SGIH0BQL15q2gCidk7Y8Ynyn30LLyxt61tDV3xNDt48/Ow93XVP6iNh2pQ2EaA9fwY7J4ULeXJ/e+HRHTFTcMqfzRUMO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=HoHMdWtr; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="HoHMdWtr" Received: from trampoline.thunk.org (pool-173-48-113-184.bstnma.fios.verizon.net [173.48.113.184]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 59CJvVqW004342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 12 Oct 2025 15:57:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1760299053; bh=LvrlMRA4RhyctjL+VzTW41Dwbxad1RspvWf+dp5Ot2s=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=HoHMdWtrdff1SHCtcqX6wdtmVUa/u1jD6A49uOJg8jSruFjKV+2XyDEyr6I5RPa98 QLuH29Q9Xilf+dEfUrjR9gd5O0HCs8r55dCssTZ+0vTRm0N8QE1kN1weHGFUvC9zDT PCuS1NrQH9Y9ND79nHd4YPtARvRu/wyeEGquMGF9ylAeNJZ6zjzGE1fLOOps5YePwk btx+ZB6iD5k3mwhoeygyLAKbf4i2iPT3Iz1DBaK+SuqNszxThAjMuBoocYC+Ho3f3R LudxDLCe2wZrNtOResiH0LjbROfgzNcvc7639EiXEdAPow48QsgvAeTT1nPL8P9Xw4 bXgDq/W6Ay+5w== Received: by trampoline.thunk.org (Postfix, from userid 15806) id 7FE332E00D9; Sun, 12 Oct 2025 15:57:31 -0400 (EDT) Date: Sun, 12 Oct 2025 15:57:31 -0400 From: "Theodore Ts'o" To: Ojaswin Mujoo Cc: Zorro Lang , fstests@vger.kernel.org, srivathsa.d.dara@oracle.com, linux-kernel@vger.kernel.org, Disha Goel Subject: Re: [PATCH] ext4/060: Skip for dax devices on non-4k page sizes Message-ID: <20251012195731.GG354523@mit.edu> References: <20251011134708.2426769-1-ojaswin@linux.ibm.com> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251011134708.2426769-1-ojaswin@linux.ibm.com> On Sat, Oct 11, 2025 at 07:17:08PM +0530, Ojaswin Mujoo wrote: > This test tries to trigger an ext4 corruption by resizing past the > meta_bg size (8GB on 4k blocksize) in ext4. Since the test is sensistive > to the size and FS layout it hardcodes the 4kb blocksize ignoring user's > $MKFS_OPTIONS. While this is okay for most cases it fails for dax based > filesystems where system pagesize is non-4k. > > One way to work past this is to make the test blocksize agnostic, but > since we still need the disk to be as big as the meta_bg size, this > means for blocksize=64kb filesystems we need a scratch disk of ~4TB > which is not feasible. > > Hence, just skip the test if fsdax is used in a non-4k page size system. > > Reported-by: Disha Goel > Signed-off-by: Ojaswin Mujoo Makes sense to me. Reviewed-by: Theodore Ts'o