From: "Darrick J. Wong" <djwong@kernel.org>
To: Naohiro Aota <Naohiro.Aota@wdc.com>
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Zorro Lang <zlang@redhat.com>, hch <hch@lst.de>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Hans Holmberg <Hans.Holmberg@wdc.com>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
Carlos Maiolino <cem@kernel.org>
Subject: Re: [PATCH v5 2/3] common/zoned: add helpers for creation and teardown of zloop devices
Date: Fri, 17 Oct 2025 09:35:00 -0700 [thread overview]
Message-ID: <20251017163500.GC3356773@frogsfrogsfrogs> (raw)
In-Reply-To: <DDK6JMVR67I6.2RADBK222K8SX@wdc.com>
On Fri, Oct 17, 2025 at 12:44:35AM +0000, Naohiro Aota wrote:
> On Fri Oct 17, 2025 at 12:50 AM JST, Johannes Thumshirn wrote:
> > On 10/16/25 5:48 PM, Darrick J. Wong wrote:
> >> Same question as last time: shouldn't we only echo this if the
> >> zloop-control write succeeds?
> >
> > Damn, I thought I've did that.
>
> Maybe, it's good to call _fail as _create_loop_device() do.
Does that actually work? _create_loop_dev is often called in a subshell
to capture the device name, so the exit 1 in _fail will exit the
subshell, which won't exit the test. Right?
zdev=$(_create_zloop_device) || _fail "could not create zloop"
Though if you're standing up a zloop to test zloop, then a zloop
creation failure ought to cause _notrun.
--D
next prev parent reply other threads:[~2025-10-17 16:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 15:20 [PATCH v5 0/3] fstests: basic smoke test on zoned loop device Johannes Thumshirn
2025-10-16 15:20 ` [PATCH v5 1/3] common/zoned: add _require_zloop Johannes Thumshirn
2025-10-16 23:49 ` Naohiro Aota
2025-10-16 15:20 ` [PATCH v5 2/3] common/zoned: add helpers for creation and teardown of zloop devices Johannes Thumshirn
2025-10-16 15:48 ` Darrick J. Wong
2025-10-16 15:50 ` Johannes Thumshirn
2025-10-17 0:44 ` Naohiro Aota
2025-10-17 16:35 ` Darrick J. Wong [this message]
2025-10-17 18:38 ` Zorro Lang
2025-10-16 15:20 ` [PATCH v5 3/3] generic: basic smoke for filesystems on zoned block devices Johannes Thumshirn
2025-10-16 15:49 ` Darrick J. Wong
2025-10-16 23:48 ` Naohiro Aota
2025-10-16 23:54 ` Anand Jain
2025-10-17 4:17 ` Christoph Hellwig
2025-10-17 18:56 ` Zorro Lang
2025-10-18 11:13 ` Johannes Thumshirn
2025-10-18 14:05 ` Zorro Lang
2025-10-20 6:21 ` Johannes Thumshirn
2025-10-21 9:33 ` Johannes Thumshirn
2025-10-21 14:49 ` Darrick J. Wong
2025-10-22 4:32 ` hch
2025-10-22 7:24 ` Zorro Lang
2025-10-22 7:34 ` hch
2025-10-22 4:35 ` hch
2025-10-22 6:27 ` Johannes Thumshirn
2025-10-22 6:33 ` hch
2025-10-20 7:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017163500.GC3356773@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=Hans.Holmberg@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=cem@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox