public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Andrey Albershteyn <aalbersh@redhat.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org,
	zlang@redhat.com, Andrey Albershteyn <aalbersh@kernel.org>
Subject: Re: [PATCH 1/3] common/filter: add missing file attribute
Date: Mon, 20 Oct 2025 09:46:24 -0700	[thread overview]
Message-ID: <20251020164624.GP6178@frogsfrogsfrogs> (raw)
In-Reply-To: <20251020135530.1391193-2-aalbersh@kernel.org>

On Mon, Oct 20, 2025 at 03:55:28PM +0200, Andrey Albershteyn wrote:
> Add n (nosymlinks) char according to xfsprogs io/attr.c
> 
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>

The updated version of "common/filter: fix _filter_file_attributes to
handle xfs file flags" that I'm about to send will fix this up by
documenting that _filter_file_attributes only handles xfs attrs and then
making it handle all the known flags.

--D

> ---
>  common/filter | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/filter b/common/filter
> index c3a751dd0c39..28048b4b601b 100644
> --- a/common/filter
> +++ b/common/filter
> @@ -692,7 +692,7 @@ _filter_sysfs_error()
>  _filter_file_attributes()
>  {
>  	if [[ $1 == ~* ]]; then
> -		regex=$(echo "[aAcCdDeEfFijmNpPsrStTuxVX]" | tr -d "$1")
> +		regex=$(echo "[aAcCdDeEfFijmnNpPrsStTuVxX]" | tr -d "$1")
>  	else
>  		regex="$1"
>  	fi
> -- 
> 2.50.1
> 
> 

  reply	other threads:[~2025-10-20 16:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 13:55 [PATCH 0/3] generic/772: split and fix Andrey Albershteyn
2025-10-20 13:55 ` [PATCH 1/3] common/filter: add missing file attribute Andrey Albershteyn
2025-10-20 16:46   ` Darrick J. Wong [this message]
2025-10-21  9:42     ` Andrey Albershteyn
2025-10-20 13:55 ` [PATCH 2/3] generic/772: require filesystem to support file_[g|s]etattr Andrey Albershteyn
2025-10-20 16:45   ` Darrick J. Wong
2025-10-21  9:42     ` Andrey Albershteyn
2025-10-20 13:55 ` [PATCH 3/3] generic/772: split this test into 772 and 773 for regular and special files Andrey Albershteyn
2025-10-20 16:45   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251020164624.GP6178@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=aalbersh@kernel.org \
    --cc=aalbersh@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox