From: "Darrick J. Wong" <djwong@kernel.org>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Zorro Lang <zlang@redhat.com>, hch <hch@lst.de>,
Naohiro Aota <Naohiro.Aota@wdc.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Hans Holmberg <Hans.Holmberg@wdc.com>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
Carlos Maiolino <cem@kernel.org>,
Carlos Maiolino <cmaiolino@redhat.com>
Subject: Re: [PATCH v5 3/3] generic: basic smoke for filesystems on zoned block devices
Date: Tue, 21 Oct 2025 07:49:20 -0700 [thread overview]
Message-ID: <20251021144920.GH3356773@frogsfrogsfrogs> (raw)
In-Reply-To: <16e539fe-b9f0-4645-b135-3930df249eab@wdc.com>
On Tue, Oct 21, 2025 at 09:33:05AM +0000, Johannes Thumshirn wrote:
> On 10/20/25 8:21 AM, Johannes Thumshirn wrote:
> > On 10/18/25 4:05 PM, Zorro Lang wrote:
> >> On Sat, Oct 18, 2025 at 11:13:03AM +0000, Johannes Thumshirn wrote:
> >>> On 10/17/25 8:56 PM, Zorro Lang wrote:
> >>>> Does this mean the current FSTYP doesn't support zoned?
> >>>>
> >>>> As this's a generic test case, the FSTYP can be any other filesystems, likes
> >>>> nfs, cifs, overlay, exfat, tmpfs and so on, can we create zloop on any of them?
> >>>> If not, how about _notrun if current FSTYP doesn't support.
> >>> I did that in v1 and got told that I shouldn't do this.
> >> This's your V1, right?
> >> https://lore.kernel.org/fstests/20251007041321.GA15727@lst.de/T/#u
> >>
> >> Which line is "_notrun if current FSTYP doesn't support zloop creation"? And where is
> >> the message that told you don't to that? Could you provides more details, I'd like
> >> to learn about more, thanks :)
> > Ah sh*t, it was a non public 1st version. It had a check like this:
> >
> >
> > _require_zoned_support()
> > {
> > case "$FSTYP"
> > btrfs)
> > test -f /sys/fs/btrfs/features/zoned
> > ;;
> > f2fs)
> > test -f /sys/fs/f2fs/features/blkzoned
> > ;;
> > xfs)
> > true
> > ;;
> > *)
> > false
> > ;;
> > esac
> >
> > }
> >
> > But as xfs doesn't have a features sysfs entry Christoph said, it'll be
> > better to just _try_mkfs and see if there are any errors.
> >
> >
> Zorro,
>
> Should I bring that helper back so all FSes but f2fs, btrfs and xfs are
> skipped and then still use _try_mkfs so xfs without zoned RT support is
> skipped?
Except for zonefs, I think you probably have to try mkfsing the zoned
block device to decide if the fs really works because the others all had
zone support added after the initial release.
--D
next prev parent reply other threads:[~2025-10-21 14:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 15:20 [PATCH v5 0/3] fstests: basic smoke test on zoned loop device Johannes Thumshirn
2025-10-16 15:20 ` [PATCH v5 1/3] common/zoned: add _require_zloop Johannes Thumshirn
2025-10-16 23:49 ` Naohiro Aota
2025-10-16 15:20 ` [PATCH v5 2/3] common/zoned: add helpers for creation and teardown of zloop devices Johannes Thumshirn
2025-10-16 15:48 ` Darrick J. Wong
2025-10-16 15:50 ` Johannes Thumshirn
2025-10-17 0:44 ` Naohiro Aota
2025-10-17 16:35 ` Darrick J. Wong
2025-10-17 18:38 ` Zorro Lang
2025-10-16 15:20 ` [PATCH v5 3/3] generic: basic smoke for filesystems on zoned block devices Johannes Thumshirn
2025-10-16 15:49 ` Darrick J. Wong
2025-10-16 23:48 ` Naohiro Aota
2025-10-16 23:54 ` Anand Jain
2025-10-17 4:17 ` Christoph Hellwig
2025-10-17 18:56 ` Zorro Lang
2025-10-18 11:13 ` Johannes Thumshirn
2025-10-18 14:05 ` Zorro Lang
2025-10-20 6:21 ` Johannes Thumshirn
2025-10-21 9:33 ` Johannes Thumshirn
2025-10-21 14:49 ` Darrick J. Wong [this message]
2025-10-22 4:32 ` hch
2025-10-22 7:24 ` Zorro Lang
2025-10-22 7:34 ` hch
2025-10-22 4:35 ` hch
2025-10-22 6:27 ` Johannes Thumshirn
2025-10-22 6:33 ` hch
2025-10-20 7:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021144920.GH3356773@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=Hans.Holmberg@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=cem@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox