Re: [PATCH] ext4/048: Fix hangup due to no free inodes

Baokun Li
2025-10-28T11:34:39Z

On 2025-10-28 17:39, Ojaswin Mujoo wrote:
> On Tue, Oct 28, 2025 at 03:57:00PM +0800, Baokun Li wrote:
>> On 2025-10-28 15:17, Ojaswin Mujoo wrote:
>>> We currently mkfs a 128MB filesystem, which gives use ~2048 free inodes
>>> on 64k blocksize. The test then keeps adding new files to a directory to
>>> trigger an htree split. For 64k this takes more than the total free
>>> inodes, which causes touch to return -ENOSPC. This leads to the while
>>> loop in induce_node_split() to never finish.
>>>
>>> To fix this:
>>> 1. Format a 1G FS which gives us atleast 16K inodes to work with.
>>> 2. _fail if there's any error while trying to induce node split, so we
>>> dont get stuck in loop
>>>
>>> Fixes: 466ddbfd1151 ("ext4: add test for ext4_dir_entry2 wipe")
>>> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
>>> ---
>> Yeah, I also hit this issue when testing LBS — file creation kept failing
>> without breaking out of the loop, which resulted in the test case spinning
>> endlessly.
>>
>> Looks good to me. Feel free to add:
>>
>> Reviewed-by: Baokun Li <libaokun1@huawei.com>
> Hi Baokun, I was planning to CC you since I thought you might've hit it,
> but missed it while sending the mail.

No worries, the mailing list can see it as well.

Thanks for testing and fixing this. 🤝

Cheers,
Baokun