Re: [PATCH 02/33] generic/740: don't run this test for fuse ext* implementations

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Oct 30, 2025 at 10:59:00AM +0100, Amir Goldstein wrote:
> On Wed, Oct 29, 2025 at 2:30 AM Darrick J. Wong <djwong@kernel.org> wrote:
> >
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > mke2fs disables foreign filesystem detection no matter what type you
> > pass in, so we need to block this for both fuse server variants.
> >
> > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> > ---
> >  common/rc         |    2 +-
> >  tests/generic/740 |    1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> >
> > diff --git a/common/rc b/common/rc
> > index 3fe6f53758c05b..18d11e2c5cad3a 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -1889,7 +1889,7 @@ _do()
> >  #
> >  _exclude_fs()
> >  {
> > -       [ "$1" = "$FSTYP" ] && \
> > +       [[ $FSTYP =~ $1 ]] && \
> >                 _notrun "not suitable for this filesystem type: $FSTYP"
> 
> If you accept my previous suggestion of MKFSTYP, then could add:
> 
>        [[ $MKFSTYP =~ $1 ]] && \
>                _notrun "not suitable for this filesystem on-disk
> format: $MKFSTYP"
> 
> 
> >  }
> >
> > diff --git a/tests/generic/740 b/tests/generic/740
> > index 83a16052a8a252..e26ae047127985 100755
> > --- a/tests/generic/740
> > +++ b/tests/generic/740
> > @@ -17,6 +17,7 @@ _begin_fstest mkfs auto quick
> >  _exclude_fs ext2
> >  _exclude_fs ext3
> >  _exclude_fs ext4
> > +_exclude_fs fuse.ext[234]
> >  _exclude_fs jfs
> >  _exclude_fs ocfs2
> >  _exclude_fs udf
> >
> >
> 
> And then you wont need to add fuse.ext[234] to exclude list
> 
> At the (very faint) risk of having a test that only wants to exclude ext4 and
> does not want to exclude fuse.ext4, I think this is worth it.

I guess we could try to do [[ $MKFSTYP =~ ^$1 ]]; ?

--D

> Thanks,
> Amir.
>