public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Baokun Li <libaokun1@huawei.com>,
	zlang@redhat.com, neal@gompa.dev, fstests@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	joannelkoong@gmail.com, bernd@bsbernd.com
Subject: [PATCH v6.1 04/33] common/rc: skip test if swapon doesn't work
Date: Wed, 12 Nov 2025 14:29:20 -0800	[thread overview]
Message-ID: <20251112222920.GO196358@frogsfrogsfrogs> (raw)
In-Reply-To: <20251112200540.GD3131573@mit.edu>

From: Darrick J. Wong <djwong@kernel.org>

In _require_scratch_swapfile, skip the test if swapon fails for whatever
reason, just like all the other filesystems.  There are certain ext4
configurations where swapon isn't supported, such as S_DAX files on
pmem, and (for now) blocksize > pagesize filesystems.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
v6.1: clobber all the ext-specific stuff
---
 common/rc |   25 ++++---------------------
 1 file changed, 4 insertions(+), 21 deletions(-)

diff --git a/common/rc b/common/rc
index b62e21f778d938..564235ea2e995c 100644
--- a/common/rc
+++ b/common/rc
@@ -3268,27 +3268,10 @@ _require_scratch_swapfile()
 	# Minimum size for mkswap is 10 pages
 	_format_swapfile "$SCRATCH_MNT/swap" $(($(_get_page_size) * 10)) > /dev/null
 
-	# ext* has supported all variants of swap files since their
-	# introduction, so swapon should not fail.
-	case "$FSTYP" in
-	ext2|ext3|ext4)
-		if ! swapon "$SCRATCH_MNT/swap" >/dev/null 2>&1; then
-			if _check_s_dax "$SCRATCH_MNT/swap" 1 >/dev/null; then
-				_scratch_unmount
-				_notrun "swapfiles are not supported"
-			else
-				_scratch_unmount
-				_fail "swapon failed for $FSTYP"
-			fi
-		fi
-		;;
-	*)
-		if ! swapon "$SCRATCH_MNT/swap" >/dev/null 2>&1; then
-			_scratch_unmount
-			_notrun "swapfiles are not supported"
-		fi
-		;;
-	esac
+	if ! swapon "$SCRATCH_MNT/swap" >/dev/null 2>&1; then
+		_scratch_unmount
+		_notrun "swapon failed for $FSTYP"
+	fi
 
 	swapoff "$SCRATCH_MNT/swap" >/dev/null 2>&1
 	_scratch_unmount

  reply	other threads:[~2025-11-12 22:29 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251029002755.GK6174@frogsfrogsfrogs>
2025-10-29  0:42 ` [PATCHSET v6] fstests: support ext4 fuse testing Darrick J. Wong
2025-10-29  1:20   ` [PATCH 01/33] misc: adapt tests to handle the fuse ext[234] drivers Darrick J. Wong
2025-10-30  9:51     ` Amir Goldstein
2025-11-05 22:53       ` Darrick J. Wong
2025-11-06  8:58         ` Amir Goldstein
2025-11-06 23:12           ` Darrick J. Wong
2025-11-07  7:50             ` Amir Goldstein
2025-11-07  7:08         ` Zorro Lang
2025-10-29  1:20   ` [PATCH 02/33] generic/740: don't run this test for fuse ext* implementations Darrick J. Wong
2025-10-30  9:59     ` Amir Goldstein
2025-11-05 22:56       ` Darrick J. Wong
2025-11-06  9:02         ` Amir Goldstein
2025-10-29  1:21   ` [PATCH 03/33] ext/052: use popdir.pl for much faster directory creation Darrick J. Wong
2025-10-29  1:21   ` [PATCH 04/33] common/rc: skip test if swapon doesn't work Darrick J. Wong
2025-11-12  6:35     ` Baokun Li
2025-11-12 18:26       ` Darrick J. Wong
2025-11-12 20:05         ` Theodore Ts'o
2025-11-12 22:29           ` Darrick J. Wong [this message]
2025-11-13  1:51             ` [PATCH v6.1 " Baokun Li
2025-11-13 15:52             ` Theodore Ts'o
2025-10-29  1:21   ` [PATCH 05/33] common/rc: streamline _scratch_remount Darrick J. Wong
2025-10-29  1:21   ` [PATCH 06/33] ext/039: require metadata journalling Darrick J. Wong
2025-10-29  1:22   ` [PATCH 07/33] populate: don't check for htree directories on fuse.ext4 Darrick J. Wong
2025-10-29  1:22   ` [PATCH 08/33] misc: convert _scratch_mount -o remount to _scratch_remount Darrick J. Wong
2025-10-29  1:22   ` [PATCH 09/33] misc: use explicitly $FSTYP'd mount calls Darrick J. Wong
2025-10-29  1:23   ` [PATCH 10/33] common/ext4: explicitly format with $FSTYP Darrick J. Wong
2025-10-29  1:23   ` [PATCH 11/33] tests/ext*: refactor open-coded _scratch_mkfs_sized calls Darrick J. Wong
2025-10-29  1:23   ` [PATCH 12/33] generic/732: disable for fuse.ext4 Darrick J. Wong
2025-10-29  1:23   ` [PATCH 13/33] defrag: fix ext4 defrag ioctl test Darrick J. Wong
2025-10-29  1:24   ` [PATCH 14/33] misc: explicitly require online resize support Darrick J. Wong
2025-10-29  1:24   ` [PATCH 15/33] ext4/004: disable for fuse2fs Darrick J. Wong
2025-10-29  1:24   ` [PATCH 16/33] generic/679: " Darrick J. Wong
2025-10-29  1:24   ` [PATCH 17/33] ext4/045: don't run the long dirent test on fuse2fs Darrick J. Wong
2025-10-29  1:25   ` [PATCH 18/33] generic/338: skip test if we can't mount with strictatime Darrick J. Wong
2025-10-29  1:25   ` [PATCH 19/33] generic/563: fuse doesn't support cgroup-aware writeback accounting Darrick J. Wong
2025-10-29  1:25   ` [PATCH 20/33] misc: use a larger buffer size for pwrites Darrick J. Wong
2025-10-29  1:25   ` [PATCH 21/33] ext4/046: don't run this test if dioread_nolock not supported Darrick J. Wong
2025-10-29  1:26   ` [PATCH 22/33] generic/631: don't run test if we can't mount overlayfs Darrick J. Wong
2025-10-30 11:35     ` Amir Goldstein
2025-11-05 23:12       ` Darrick J. Wong
2025-11-06  9:23         ` Amir Goldstein
2025-11-06 16:02           ` Darrick J. Wong
2025-10-29  1:26   ` [PATCH 23/33] generic/{409,410,411,589}: check for stacking mount support Darrick J. Wong
2025-10-30 10:25     ` Amir Goldstein
2025-11-05 22:58       ` Darrick J. Wong
2025-10-29  1:26   ` [PATCH 24/33] generic: add _require_hardlinks to tests that require hardlinks Darrick J. Wong
2025-10-29  1:26   ` [PATCH 25/33] ext4/001: check for fiemap support Darrick J. Wong
2025-10-29  1:27   ` [PATCH 26/33] generic/622: check that strictatime/lazytime actually work Darrick J. Wong
2025-10-29  1:27   ` [PATCH 27/33] generic/050: skip test because fuse2fs doesn't have stable output Darrick J. Wong
2025-10-30 10:05     ` Amir Goldstein
2025-11-05 23:02       ` Darrick J. Wong
2025-10-29  1:27   ` [PATCH 28/33] generic/405: don't stall on mkfs asking for input Darrick J. Wong
2025-10-29  1:27   ` [PATCH 29/33] ext4/006: fix this test Darrick J. Wong
2025-10-29  1:28   ` [PATCH 30/33] ext4/009: fix ENOSPC errors Darrick J. Wong
2025-10-29  1:28   ` [PATCH 31/33] ext4/022: enabl Darrick J. Wong
2025-10-29  6:03     ` Darrick J. Wong
2025-10-29  1:28   ` [PATCH 32/33] generic/730: adapt test for fuse filesystems Darrick J. Wong
2025-10-29  1:29   ` [PATCH 33/33] fuse2fs: hack around weird corruption problems Darrick J. Wong
2025-10-29  9:35   ` [PATCHSET v6] fstests: support ext4 fuse testing Christoph Hellwig
2025-10-29 23:52     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251112222920.GO196358@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=bernd@bsbernd.com \
    --cc=fstests@vger.kernel.org \
    --cc=joannelkoong@gmail.com \
    --cc=libaokun1@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=neal@gompa.dev \
    --cc=tytso@mit.edu \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox