Re: [PATCH] common/rc: fix _xfs_is_realtime_file for internal rt devices

Darrick J. Wong
2025-11-21T16:20:38Z

On Thu, Nov 20, 2025 at 10:47:14PM -0800, Christoph Hellwig wrote:
> On Thu, Nov 20, 2025 at 03:15:36PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Now that we can have internal realtime devices, it's possible to have a
> > realtime filesystem without setting USE_EXTERNAL=yes or SCRATCH_RTDEV.
> > Use the existing _xfs_has_feature helper to figure out if the given path
> > points to a filesystem with an online realtime volume.
>
> Looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> although right now it should not matter - one user of
> _xfs_is_realtime_file requires reflinks and the other explicitly
> excludes zoned file systems.

I know; I found this by observing that one of the new xfs_healer tests
wasn't working quite right on internal-zoned xfs. There wouldn't be
much point in citing xfs/1899 as the discovery point. :(

--D