From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: zlang@kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] common/rc: fix _xfs_is_realtime_file for internal rt devices
Date: Fri, 21 Nov 2025 08:20:37 -0800 [thread overview]
Message-ID: <20251121162037.GG196391@frogsfrogsfrogs> (raw)
In-Reply-To: <aSAK8qG0vFjK79z4@infradead.org>
On Thu, Nov 20, 2025 at 10:47:14PM -0800, Christoph Hellwig wrote:
> On Thu, Nov 20, 2025 at 03:15:36PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Now that we can have internal realtime devices, it's possible to have a
> > realtime filesystem without setting USE_EXTERNAL=yes or SCRATCH_RTDEV.
> > Use the existing _xfs_has_feature helper to figure out if the given path
> > points to a filesystem with an online realtime volume.
>
> Looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> although right now it should not matter - one user of
> _xfs_is_realtime_file requires reflinks and the other explicitly
> excludes zoned file systems.
I know; I found this by observing that one of the new xfs_healer tests
wasn't working quite right on internal-zoned xfs. There wouldn't be
much point in citing xfs/1899 as the discovery point. :(
--D
prev parent reply other threads:[~2025-11-21 16:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 16:08 [PATCH 0/2] xfs: add regression test for small zone capacity cem
2025-11-20 16:08 ` [PATCH 1/2] common/zoned: enable passing a custom capacity cem
2025-11-21 6:46 ` Johannes Thumshirn
2025-11-21 6:50 ` Christoph Hellwig
2025-11-22 7:41 ` Zorro Lang
2025-11-20 16:08 ` [PATCH 2/2] xfs: Add test for mkfs with smaller zone capacity cem
2025-11-21 6:51 ` Christoph Hellwig
2025-11-21 6:51 ` Johannes Thumshirn
2025-11-21 6:57 ` hch
2025-11-21 7:00 ` Johannes Thumshirn
2025-11-21 8:34 ` Hans Holmberg
2025-11-24 15:27 ` Carlos Maiolino
2025-11-24 17:31 ` Johannes Thumshirn
2025-11-24 17:34 ` hch
2025-11-25 13:01 ` Carlos Maiolino
2025-11-22 8:36 ` Zorro Lang
2025-11-24 16:04 ` Carlos Maiolino
2025-11-20 23:15 ` [PATCH] common/rc: fix _xfs_is_realtime_file for internal rt devices Darrick J. Wong
2025-11-20 23:24 ` Darrick J. Wong
2025-11-21 6:47 ` Christoph Hellwig
2025-11-21 16:20 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121162037.GG196391@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox