public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	zlang@kernel.org, fstests@vger.kernel.org,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: add a test that zoned file systems with rump RTG can't be mounted
Date: Wed, 10 Dec 2025 17:57:06 +0100	[thread overview]
Message-ID: <20251210165706.GB9489@lst.de> (raw)
In-Reply-To: <20251210165028.GC7725@frogsfrogsfrogs>

On Wed, Dec 10, 2025 at 08:50:28AM -0800, Darrick J. Wong wrote:
> > +_scratch_mkfs > /dev/null 2>&1
> > +blocks=$(_scratch_xfs_db -c 'sb 0' -c 'print rblocks' | awk '{print $3}')
> 
> blocks="$(_scratch_xfs_get_metadata_field rblocks 'sb 0')"

Ah, I had a vague memory something like this existed but could not
find it.

> > +blocks=$((blocks - 4096))
> > +_scratch_xfs_db -x -c 'sb 0' -c "write -d rblocks $blocks" > /dev/null 2>&1
> > +_scratch_xfs_db -x -c 'sb 0' -c "write -d rextents $blocks" > /dev/null 2>&1
> > +_try_scratch_mount || _notrun "Can't mount rump RTG file system"
> 
> Doesn't the _notrun here cause the test to be "skipped" when in fact it
> actually exhibits the behavior that you want (i.e. it passes)?

Yes.  Which sort of does what's intended (fail on broken behavior) but
in a very odd way.  I'll do this in a nicer way.


      reply	other threads:[~2025-12-10 16:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10 14:23 [PATCH] xfs: add a test that zoned file systems with rump RTG can't be mounted Christoph Hellwig
2025-12-10 16:50 ` Darrick J. Wong
2025-12-10 16:57   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251210165706.GB9489@lst.de \
    --to=hch@lst.de \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox