From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: Anand Jain <asj@kernel.org>, Filipe Manana <fdmanana@suse.com>,
"Darrick J. Wong" <djwong@kernel.org>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: [PATCH 07/13] xfs/185: don't use SCRATCH_{,RT}DEV helpers
Date: Fri, 12 Dec 2025 09:21:55 +0100 [thread overview]
Message-ID: <20251212082210.23401-8-hch@lst.de> (raw)
In-Reply-To: <20251212082210.23401-1-hch@lst.de>
This tests creates loop-based data and rt devices for testing. Don't
override SCRATCH_{,RT}DEV and don't use the helpers based on it because
the options specified in MKFS_OPTIONS might not work for this
configuration. This also means that we will now never use a log device
for this test even if SCRATCH_LOGDEV was set, which is fine because the
log device is not relevant for what is tested.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
---
tests/xfs/185 | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/tests/xfs/185 b/tests/xfs/185
index 7aceb383ce46..84139be8e66e 100755
--- a/tests/xfs/185
+++ b/tests/xfs/185
@@ -22,12 +22,11 @@ _cleanup()
{
cd /
rm -r -f $tmp.*
- _scratch_unmount
+ umount $SCRATCH_MNT
test -n "$ddloop" && _destroy_loop_device "$ddloop"
test -n "$rtloop" && _destroy_loop_device "$rtloop"
test -n "$ddfile" && rm -f "$ddfile"
test -n "$rtfile" && rm -f "$rtfile"
- test -n "$old_use_external" && USE_EXTERNAL="$old_use_external"
}
_require_test
@@ -64,16 +63,8 @@ rtminor=$(stat -c '%T' "$rtloop")
test $ddmajor -le $rtmajor || \
_notrun "Data loopdev minor $ddminor larger than rt minor $rtminor"
-# Inject our custom-built devices as an rt-capable scratch device.
-# We avoid touching "require_scratch" so that post-test fsck will not try to
-# run on our synthesized scratch device.
-old_use_external="$USE_EXTERNAL"
-USE_EXTERNAL=yes
-SCRATCH_RTDEV="$rtloop"
-SCRATCH_DEV="$ddloop"
-
-_scratch_mkfs >> $seqres.full
-_try_scratch_mount >> $seqres.full || \
+$MKFS_XFS_PROG -r rtdev=$rtloop $ddloop >> $seqres.full
+mount -o rtdev=$rtloop $ddloop $SCRATCH_MNT >> $seqres.full || \
_notrun "mount with injected rt device failed"
# Create a file that we'll use to seed fsmap entries for the rt device,
--
2.47.3
next prev parent reply other threads:[~2025-12-12 8:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 8:21 stop overriding SCRATCH_{,LOG,RT}DEV v2 Christoph Hellwig
2025-12-12 8:21 ` [PATCH 01/13] dmflakey: override SCRATCH_DEV in _init_flakey Christoph Hellwig
2025-12-12 20:11 ` Darrick J. Wong
2025-12-15 5:29 ` Christoph Hellwig
2025-12-15 19:41 ` Darrick J. Wong
2025-12-17 16:59 ` Anand Jain
2025-12-12 8:21 ` [PATCH 02/13] ext4/006: call e2fsck directly Christoph Hellwig
2025-12-12 20:02 ` Darrick J. Wong
2025-12-15 5:27 ` Christoph Hellwig
2025-12-15 19:42 ` Darrick J. Wong
2025-12-17 17:01 ` Anand Jain
2025-12-12 8:21 ` [PATCH 03/13] common: add a _check_dev_fs helper Christoph Hellwig
2025-12-17 17:01 ` Anand Jain
2025-12-12 8:21 ` [PATCH 04/13] ext4/032: use _check_dev_fs Christoph Hellwig
2025-12-17 17:02 ` Anand Jain
2025-12-12 8:21 ` [PATCH 05/13] generic/590: split XFS RT specific bits out Christoph Hellwig
2025-12-17 17:02 ` Anand Jain
2025-12-12 8:21 ` [PATCH 06/13] xfs/157: don't override SCRATCH_{,LOG,RT}DEV Christoph Hellwig
2025-12-12 8:21 ` Christoph Hellwig [this message]
2025-12-12 8:21 ` [PATCH 08/13] xfs/424: don't use SCRATCH_DEV helpers Christoph Hellwig
2025-12-12 8:21 ` [PATCH 09/13] xfs/521: require a real SCRATCH_RTDEV Christoph Hellwig
2025-12-12 8:21 ` [PATCH 10/13] xfs/521: call _require_scratch_size Christoph Hellwig
2025-12-12 20:01 ` Darrick J. Wong
2025-12-12 8:21 ` [PATCH 11/13] xfs/528: require a real SCRATCH_RTDEV Christoph Hellwig
2025-12-12 20:00 ` Darrick J. Wong
2025-12-12 8:22 ` [PATCH 12/13] xfs/530: " Christoph Hellwig
2025-12-12 20:00 ` Darrick J. Wong
2025-12-12 8:22 ` [PATCH 13/13] xfs/650: " Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2025-12-18 7:29 stop overriding SCRATCH_{,LOG,RT}DEV v3 Christoph Hellwig
2025-12-18 7:30 ` [PATCH 07/13] xfs/185: don't use SCRATCH_{,RT}DEV helpers Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251212082210.23401-8-hch@lst.de \
--to=hch@lst.de \
--cc=asj@kernel.org \
--cc=djwong@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox