Re: [PATCH fstests v3 3/3] generic: add tests for file delegations

["Darrick J. Wong" <djwong@kernel.org>]

On Sun, Dec 07, 2025 at 03:35:29AM +0900, Jeff Layton wrote:
> On Sat, 2025-12-06 at 01:25 +0800, Zorro Lang wrote:
> > On Wed, Dec 03, 2025 at 10:43:09AM -0500, Jeff Layton wrote:
> > > Mostly the same ones as leases, but some additional tests to validate
> > > that they are broken on metadata changes.
> > > 
> > > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > > ---
> > 
> > This version is good to me. But this test fails without the:
> > https://lore.kernel.org/linux-fsdevel/20251201-dir-deleg-ro-v1-1-2e32cf2df9b7@kernel.org/
> > 
> 
> 
> Thanks. Yes, that bug is unfortunate. I'm hoping Christian will take
> that patch in soon so all of the tests will pass.
> 
> > So maybe we can mark that:
> > 
> >   _fixed_by_kernel_commit xxxxxxxxxxxx ...
> > 
> > or
> > 
> >   _wants_kernel_commit xxxxxxxxxxxx ...
> > 
> > Anyway, we can add that after the patchset get merged. I'll merge this patchset
> > at first.
> > 
> > Reviewed-by: Zorro Lang <zlang@redhat.com>
> 
> If you like. This functionality is only in v6.19-rc so far, so there is
> no released kernel that has this (yet).

Hi Jeff/Zorro,

Having rebased on 6.19-rc1, I now see that generic/787 (this test) fails
with:

 --- /run/fstests/bin/tests/generic/787.out	2025-12-09 09:18:49.076881595 -0800
 +++ /var/tmp/fstests/generic/787.out.bad	2025-12-16 07:23:40.092000000 -0800
 @@ -1,2 +1,4 @@
  QA output created by 787
 -success!
 +ls: cannot access '/mnt/dirdeleg': No such file or directory
 +Server reported failure (2)
 +(see /var/tmp/fstests/generic/787.full for details)

The 787.full file contains:

      ***** Client log *****
 10 tests run, 0 failed
      ***** Server log *****
      ***** Server failure *****
      in test 3, while Set Delegationing using offset 1, length 0 - err = 0:Success
      3:Fail Write Deleg if file is open somewhere else
      ***** Server failure *****
      in test 3, while Get Delegationing using offset 1, length 0 - err = 0:Success
      3:Fail Write Deleg if file is open somewhere else
      ***** Server failure *****
      in test 4, while Set Delegationing using offset 0, length 0 - err = 0:Success
      4:Fail Read Deleg if opened with write permissions
      ***** Server failure *****
      in test 4, while Get Delegationing using offset 0, length 0 - err = 0:Success
      4:Fail Read Deleg if opened with write permissions
 13 tests run, 2 failed
      ***** End file details *****
 Server reported failure (2)

(Apparently this test would _notrun in 6.18-rc)

Is this the failure fixed by the patch above?  If so, I'll ignore the
failure until rc2.

--D

> Jeff Layton <jlayton@kernel.org>
>