Re: [PATCH] fstests: fix flaky device name in _cleanup_flakey

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Dec 18, 2025 at 01:00:22AM +0800, Anand Jain wrote:
> There is no device named flakey-test, which _cleanup_flakey() currently
> uses. The actual device name is stored in $FLAKEY_NAME and is set to
> flakey-test.$seq. Use $FLAKEY_NAME instead.
> 
> Signed-off-by: Anand Jain <asj@kernel.org>

Ugh, still finding obvious bugs a year later <grumble>

Cc: <fstests@vger.kernel.org> # v2024.12.08
Fixes: 603030dee015ba ("fstests: per-test dmflakey instances")

Thanks for spotting this, Anand.

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  (apply this on top of the patchset
> 	'stop overriding SCRATCH_{,LOG,RT}DEV v2')
>  common/dmflakey | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/dmflakey b/common/dmflakey
> index cb0359901c16..6ac666f5b61e 100644
> --- a/common/dmflakey
> +++ b/common/dmflakey
> @@ -76,7 +76,7 @@ _cleanup_flakey()
>  	# otherwise the umount will hang
>  	test -n "$NON_FLAKEY_LOGDEV" && $DMSETUP_PROG resume $FLAKEY_LOGNAME &> /dev/null
>  	test -n "$NON_FLAKEY_RTDEV" && $DMSETUP_PROG resume $FLAKEY_RTNAME &> /dev/null
> -	test -n "$NON_FLAKEY_DEV" && $DMSETUP_PROG resume flakey-test > /dev/null 2>&1
> +	test -n "$NON_FLAKEY_DEV" && $DMSETUP_PROG resume $FLAKEY_NAME &> /dev/null
>  
>  	_unmount $SCRATCH_MNT > /dev/null 2>&1
>  
> -- 
> 2.43.0
> 
>