Re: [PATCH v2] generic: use _qmount_option and _qmount

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Dec 23, 2025 at 02:41:50PM +0800, Glass Su wrote:
> 
> 
> > On Dec 8, 2025, at 14:58, Su Yue <glass.su@suse.com> wrote:
> > 
> > This commit touches generic tests call `_scratch_mount -o usrquota`
> > then chmod 777, quotacheck and quotaon. They can be simpilfied
> > to _qmount_option and _qmount. _qmount already calls quotacheck,
> > quota and chmod ugo+rwx. The conversions can save a few lines.
> > 
> > Signed-off-by: Su Yue <glass.su@suse.com>
> 
> Gentle ping.

Sorry, I've been on vacation.

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> — 
> Su
> > ---
> > Changelog:
> > v2:
> >  Only convert the tests calling chmod 777.
> > ---
> > tests/generic/231 | 6 ++----
> > tests/generic/232 | 6 ++----
> > tests/generic/233 | 6 ++----
> > tests/generic/270 | 6 ++----
> > 4 files changed, 8 insertions(+), 16 deletions(-)
> > 
> > diff --git a/tests/generic/231 b/tests/generic/231
> > index ce7e62ea1886..02910523d0b5 100755
> > --- a/tests/generic/231
> > +++ b/tests/generic/231
> > @@ -47,10 +47,8 @@ _require_quota
> > _require_user
> > 
> > _scratch_mkfs >> $seqres.full 2>&1
> > -_scratch_mount "-o usrquota,grpquota"
> > -chmod 777 $SCRATCH_MNT
> > -quotacheck -u -g $SCRATCH_MNT 2>/dev/null
> > -quotaon -u -g $SCRATCH_MNT 2>/dev/null
> > +_qmount_option "usrquota,grpquota"
> > +_qmount
> > 
> > if ! _fsx 1; then
> > _scratch_unmount 2>/dev/null
> > diff --git a/tests/generic/232 b/tests/generic/232
> > index c903a5619045..21375809d299 100755
> > --- a/tests/generic/232
> > +++ b/tests/generic/232
> > @@ -44,10 +44,8 @@ _require_scratch
> > _require_quota
> > 
> > _scratch_mkfs > $seqres.full 2>&1
> > -_scratch_mount "-o usrquota,grpquota"
> > -chmod 777 $SCRATCH_MNT
> > -quotacheck -u -g $SCRATCH_MNT 2>/dev/null
> > -quotaon -u -g $SCRATCH_MNT 2>/dev/null
> > +_qmount_option "usrquota,grpquota"
> > +_qmount
> > 
> > _fsstress
> > _check_quota_usage
> > diff --git a/tests/generic/233 b/tests/generic/233
> > index 3fc1b63abb24..4606f3bde2ab 100755
> > --- a/tests/generic/233
> > +++ b/tests/generic/233
> > @@ -59,10 +59,8 @@ _require_quota
> > _require_user
> > 
> > _scratch_mkfs > $seqres.full 2>&1
> > -_scratch_mount "-o usrquota,grpquota"
> > -chmod 777 $SCRATCH_MNT
> > -quotacheck -u -g $SCRATCH_MNT 2>/dev/null
> > -quotaon -u -g $SCRATCH_MNT 2>/dev/null
> > +_qmount_option "usrquota,grpquota"
> > +_qmount
> > setquota -u $qa_user 32000 32000 1000 1000 $SCRATCH_MNT 2>/dev/null
> > 
> > _fsstress
> > diff --git a/tests/generic/270 b/tests/generic/270
> > index c3d5127a0b51..9ac829a7379f 100755
> > --- a/tests/generic/270
> > +++ b/tests/generic/270
> > @@ -62,10 +62,8 @@ _require_command "$SETCAP_PROG" setcap
> > _require_attrs security
> > 
> > _scratch_mkfs_sized $((512 * 1024 * 1024)) >> $seqres.full 2>&1
> > -_scratch_mount "-o usrquota,grpquota"
> > -chmod 777 $SCRATCH_MNT
> > -quotacheck -u -g $SCRATCH_MNT 2>/dev/null
> > -quotaon -u -g $SCRATCH_MNT 2>/dev/null
> > +_qmount_option "usrquota,grpquota"
> > +_qmount
> > 
> > if ! _workout; then
> > _scratch_unmount 2>/dev/null
> > -- 
> > 2.50.1 (Apple Git-155)
> > 
> 
>