From: Eric Biggers <ebiggers@kernel.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, djwong@kernel.org
Subject: Re: [PATCH v2 1/2] fs: add FS_XFLAG_VERITY for fs-verity files
Date: Tue, 20 Jan 2026 16:33:21 -0800 [thread overview]
Message-ID: <20260121003321.GB12110@quark> (raw)
In-Reply-To: <20260119165644.2945008-2-aalbersh@kernel.org>
On Mon, Jan 19, 2026 at 05:56:42PM +0100, Andrey Albershteyn wrote:
> /* Read-only inode flags */
> #define FS_XFLAG_RDONLY_MASK \
> - (FS_XFLAG_PREALLOC | FS_XFLAG_HASATTR)
> + (FS_XFLAG_PREALLOC | FS_XFLAG_HASATTR | FS_XFLAG_VERITY)
This is the first flag that's both a common flag and a read-only flag.
Looking at how FS_XFLAG_RDONLY_MASK gets used in
copy_fsxattr_from_user():
fileattr_fill_xflags(fa, xfa.fsx_xflags);
fa->fsx_xflags &= ~FS_XFLAG_RDONLY_MASK;
So it translates the xflags into fsflags, then clears the read-only
xflags *but not the read-only fsflags*.
If the user passed FS_XFLAG_VERITY, the result will be that
FS_XFLAG_VERITY will *not* be set in xflags, but FS_VERITY_FL will be
set in fsflags.
Is that working as intended? It seems inconsistent.
- Eric
next prev parent reply other threads:[~2026-01-21 0:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 16:56 [PATCH v2 0/2] Add traces and file attributes for fs-verity Andrey Albershteyn
2026-01-19 16:56 ` [PATCH v2 1/2] fs: add FS_XFLAG_VERITY for fs-verity files Andrey Albershteyn
2026-01-20 15:51 ` Darrick J. Wong
2026-01-21 0:33 ` Eric Biggers [this message]
2026-01-21 14:23 ` Andrey Albershteyn
2026-01-19 16:56 ` [PATCH v2 2/2] fsverity: add tracepoints Andrey Albershteyn
2026-01-21 0:39 ` Eric Biggers
2026-01-24 18:49 ` Eric Biggers
2026-01-26 11:38 ` Andrey Albershteyn
2026-01-29 15:02 ` Christian Brauner
-- strict thread matches above, loose matches on Subject: below --
2026-01-19 16:32 [PATCH v2 0/2] Add traces and file attributes for fs-verity Andrey Albershteyn
2026-01-19 16:32 ` [PATCH v2 1/2] fs: add FS_XFLAG_VERITY for fs-verity files Andrey Albershteyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121003321.GB12110@quark \
--to=ebiggers@kernel.org \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox