Re: [PATCH] xfs/841: fix the fsstress invocation

Re: [PATCH] xfs/841: fix the fsstress invocation

[Darrick J. Wong]

[cc fstests]

On Mon, Jan 26, 2026 at 02:08:16PM +0100, Christoph Hellwig wrote:
> xfs/841 fails for me with:
> 
> +/root/xfstests-dev/tests/xfs/841: line 79: -f: command not found
> 
> Looks like the recent edits missed a \ escape.  Fix that.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Doh!
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  tests/xfs/841 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/841 b/tests/xfs/841
> index b4bf538f1526..ee2368d4a746 100755
> --- a/tests/xfs/841
> +++ b/tests/xfs/841
> @@ -64,7 +64,7 @@ _create_proto_dir()
>  	rm -rf "$PROTO_DIR"
>  	mkdir -p "$PROTO_DIR"
>  
> -	FSSTRESS_ARGS=`_scale_fsstress_args -d $PROTO_DIR -s 1 -n 2000 -p 2 -z
> +	FSSTRESS_ARGS=`_scale_fsstress_args -d $PROTO_DIR -s 1 -n 2000 -p 2 -z \
>  		-f creat=15 \
>  		-f mkdir=8 \
>  		-f write=15 \
> -- 
> 2.47.3
> 
> 

Re: [PATCH] xfs/841: fix the fsstress invocation

[Zorro Lang]

On Mon, Jan 26, 2026 at 11:44:04AM -0800, Darrick J. Wong wrote:
> [cc fstests]
> 
> On Mon, Jan 26, 2026 at 02:08:16PM +0100, Christoph Hellwig wrote:
> > xfs/841 fails for me with:
> > 
> > +/root/xfstests-dev/tests/xfs/841: line 79: -f: command not found
> > 
> > Looks like the recent edits missed a \ escape.  Fix that.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Doh!
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

Thanks Christoph and Darrick, sorry I failed to push the lastest for-next
branch. You might find this failure on old patches-in-queue branch.
I did basic regression test on that branch, and I think I've found and
fixed this issue before merging into for-next last week. Could you please
pull the latest for-next branch again and see if the issue persists?

Thanks,
Zorro

> 
> --D
> 
> > ---
> >  tests/xfs/841 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/xfs/841 b/tests/xfs/841
> > index b4bf538f1526..ee2368d4a746 100755
> > --- a/tests/xfs/841
> > +++ b/tests/xfs/841
> > @@ -64,7 +64,7 @@ _create_proto_dir()
> >  	rm -rf "$PROTO_DIR"
> >  	mkdir -p "$PROTO_DIR"
> >  
> > -	FSSTRESS_ARGS=`_scale_fsstress_args -d $PROTO_DIR -s 1 -n 2000 -p 2 -z
> > +	FSSTRESS_ARGS=`_scale_fsstress_args -d $PROTO_DIR -s 1 -n 2000 -p 2 -z \
> >  		-f creat=15 \
> >  		-f mkdir=8 \
> >  		-f write=15 \
> > -- 
> > 2.47.3
> > 
> > 
>