From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: zlang@kernel.org, hans.holmberg@wdc.com,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] xfs: test zone reset error handling
Date: Tue, 27 Jan 2026 21:05:29 -0800 [thread overview]
Message-ID: <20260128050529.GM5945@frogsfrogsfrogs> (raw)
In-Reply-To: <20260128033819.GA30962@lst.de>
On Wed, Jan 28, 2026 at 04:38:19AM +0100, Christoph Hellwig wrote:
> On Tue, Jan 27, 2026 at 05:42:55PM -0800, Darrick J. Wong wrote:
> > > +# try mounting with error injection still enabled. This should fail.
> > > +_try_scratch_mount && _fail "file system mounted despite zone reset errors"
> >
> > Is it necessary to _fail here explicitly? Or could you just echo that
> > string and let the golden output disturbance cause the test to fail?
>
> The echo would work to. But why would that be prefable? Is there some
> hidden downside to _fail I haven't noticed in all the years?
Nah, I was just wondering what happens if the test keeps going instead
of exiting immediately.
--D
prev parent reply other threads:[~2026-01-28 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 16:09 [PATCH] xfs: test zone reset error handling Christoph Hellwig
2026-01-28 1:42 ` Darrick J. Wong
2026-01-28 3:38 ` Christoph Hellwig
2026-01-28 5:05 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128050529.GM5945@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox