From: Christoph Hellwig <hch@lst.de>
To: zlang@kernel.org
Cc: djwong@kernel.org, luca.dimaio1@gmail.com,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH] xfs/841: create a block device that must exist
Date: Mon, 2 Feb 2026 09:57:01 +0100 [thread overview]
Message-ID: <20260202085701.343099-1-hch@lst.de> (raw)
This test currently creates a block device node for /dev/ram0,
which isn't guaranteed to exist, and can thus cause the test to
fail with:
mkfs.xfs: cannot open $TEST_DIR/proto/blockdev: No such device or address
Instead, create a node for the backing device for $TEST_DIR, which must
exist.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/xfs/841 | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/xfs/841 b/tests/xfs/841
index ee2368d4a746..ddb1b3bea104 100755
--- a/tests/xfs/841
+++ b/tests/xfs/841
@@ -85,9 +85,12 @@ _create_proto_dir()
$here/src/af_unix "$PROTO_DIR/socket" 2> /dev/null || true
# Block device (requires root)
- mknod "$PROTO_DIR/blockdev" b 1 0 2> /dev/null || true
+ # Uses the device for $TEST_DIR to ensure it always exists.
+ mknod "$PROTO_DIR/blockdev" b $(stat -c '%Hd %Ld' $TEST_DIR) \
+ 2> /dev/null || true
# Character device (requires root)
+ # Uses /dev/null, which should always exist
mknod "$PROTO_DIR/chardev" c 1 3 2> /dev/null || true
}
--
2.47.3
next reply other threads:[~2026-02-02 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 8:57 Christoph Hellwig [this message]
2026-02-02 18:54 ` [PATCH] xfs/841: create a block device that must exist Luca Di Maio
2026-02-03 8:28 ` Zorro Lang
2026-03-03 17:53 ` Darrick J. Wong
2026-03-04 12:55 ` Christoph Hellwig
2026-03-04 16:49 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202085701.343099-1-hch@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=luca.dimaio1@gmail.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox