From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88CCC2E11D2; Fri, 6 Feb 2026 06:27:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770359237; cv=none; b=i61c6sNY4knHoibq4SlfHzPJ9jjpp1XlhilwfOCYsE7ufzbWpVwwwPG8xRtmNho04x7BMIA2if+JJQqwcJf7l9xzVft+KmqLw6RHv8bbpCYOwclDZPMzE/0x8SdJ3m9qTE4qTV2PI6G2GGm/je5NuVxWfvCxXl3HZe3FPUqBA4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770359237; c=relaxed/simple; bh=EFK7bINGhhgJnC2FGSGhoGq4drzrbQYw+dzKcFB7XRU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CZVyeoIN8vksaf7IAeFWGIj7sOwfzLh4zZH2UPqfCrrl2UvM7FSUN5kDpBkRfIDm4DTjRhRn5bFOk1P4SVOZIE+PuiuBNzxOakQEBWy/1u1zqNYAFtaq9L7v0hft7xGNXK/zCr4s1nFB547p4pVCqsfjfr/LIDXLQdM+spDjgrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oCBtn2Vx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oCBtn2Vx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1503EC116C6; Fri, 6 Feb 2026 06:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770359237; bh=EFK7bINGhhgJnC2FGSGhoGq4drzrbQYw+dzKcFB7XRU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oCBtn2Vx55VJ+hGY3lA03Ucgw6hl4etuc/Z0tBcOXcr0ySKJtDMLigp8r71Jzk98O jenOuVHhzeLuhUTxJqHZnKa4KI81/xeB+okuUEY4HDvAeUZEgtjZBJEyVV0yQE4NbL GBIsMs1web2hP532MP0DRQsY0ceGErCZ8TE5mdUTtOphpxHpEYOK+hqckKWcVD4pOU yF/yZjqkS0UC4SKxN/9eQfMDc0lGPXEMxFpQlfNupEXvuYaHdi4/4maW+8FeWReQUH ikkZyt6JntUSR6aUGz6q9TQYGi56SkB4ywKlUSg6YxI1lE0JK7pUWdEToA0QhIPD8w e2S/ofKrNBo8w== Date: Thu, 5 Feb 2026 22:27:16 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: zlang@redhat.com, linux-ext4@vger.kernel.org, fstests@vger.kernel.org Subject: Re: [PATCH 1/3] xfs/018: remove inline xattr recovery tests Message-ID: <20260206062716.GO7686@frogsfrogsfrogs> References: <177005945267.2432878.7105483366958924034.stgit@frogsfrogsfrogs> <177005945298.2432878.17951687824065765554.stgit@frogsfrogsfrogs> <20260205165624.GA7703@frogsfrogsfrogs> <20260206062222.GN7686@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 05, 2026 at 10:26:12PM -0800, Christoph Hellwig wrote: > On Thu, Feb 05, 2026 at 10:22:22PM -0800, Darrick J. Wong wrote: > > On Thu, Feb 05, 2026 at 09:59:42PM -0800, Christoph Hellwig wrote: > > > On Thu, Feb 05, 2026 at 08:56:24AM -0800, Darrick J. Wong wrote: > > > > "In Linux 7.0 we've changed the extended attribute update code to try to > > > > take a shortcut for performance reasons. Before walking through the > > > > attr intent state machine (slow), the update will check to see if the > > > > attr structure is in short format and will stay in that format after the > > > > change. If so, then the incore inode can be updated and logged, and the > > > > update is complete (fast) in a single transaction. > > > > > > > > "(Obviously, for complex attr structures or large changes we still walk > > > > through the intent machinery.) > > > > > > > > "However, xfs/018 tests the behavior of the "larp" error injector, which > > > > only triggers from inside the attr intent state machine. Therefore, the > > > > short format tests don't actually trip the injector. It makes no sense > > > > to add a new larp injection callsite for the shortcut because either the > > > > single transaction gets written to disk or it doesn't." > > > > > > Make sense, but from looking at the test I'm still a bit confused > > > why it fails (vs just not testing something too useful) > > > > The golden output no longer matches because the attr update doesn't > > return EIO and shut down the filesystem due to the larp injection. > > Ah, that's the missing bit. Can you add that blurb to the commit > message? Will do! > With that and the above: > > Reviewed-by: Christoph Hellwig Thanks! --D