From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4876D366577; Tue, 3 Mar 2026 17:59:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772560786; cv=none; b=C5M+F2Pcc/wih3O5SkKE2ThN6nCzJ5s6KpuafNtPpju8g9O1w+KEyjNKr2tT9FbSoP2QZFah668ilLBIpZxFi/liZ0IonVaGllLMT10E7rQ0qagnAAP9DbmtH+y+aNqzO82BkP4zCMOLP/nCqYAmwrOuwA9IQeJ/M+kAiNtctH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772560786; c=relaxed/simple; bh=7w4Yv3iEeerca9ZUbPzIO0+RunrJzrs7MoONu9vAzrw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YFhkRCXcE+9CvOXrYyPJEZpIyeHSTiTwP5ISQreHSIJBbZhgdEgyexWvTNsZhgLpGweXEAW2Y2KPFx7GOgjqHnRo489Af+LMnT3G5XU2NbkXQKgENloXarKxO3c8mtnuKTJc3lXDoakDk4byieTAUAs3gFah2sHJszEVkPvHFZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ji3FbPuY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ji3FbPuY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE4E9C116C6; Tue, 3 Mar 2026 17:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772560785; bh=7w4Yv3iEeerca9ZUbPzIO0+RunrJzrs7MoONu9vAzrw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ji3FbPuYUcizrCG/pFTd6Ed2+fSE7Gol20eivW+pSW1siolnXkL6ykgYVjZKdnSBy YF4CvJr8tBX+NILNkL5xawompxRfORJFSICOplscgVnxAq0faQvLPITYuwrSMayjDb G8sjRLbCH6/OmyoQGTKO/nKq8dZk+gLqGxMcNMOZkkU43sqE+1zzDj0RxfJ+WfJCOn cGtvCQmnmGvcfK4445BXgcPNJ5fvxHHfY2sIsLuBT0liD2I4J00Js5rWrxWFM7V6Bf lW0CEGUKyQzRvxJV7uPkG4jPeXaOKLX480scoJQ/eK3KolfP7tpRZCrJbh+BBd8K2D 0MaZ9TU0ZobmQ== Date: Tue, 3 Mar 2026 09:59:45 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: zlang@redhat.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gabriel@krisman.be, amir73il@gmail.com, jack@suse.cz, fstests@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/1] generic: test fsnotify filesystem error reporting Message-ID: <20260303175945.GE13843@frogsfrogsfrogs> References: <177249785452.483405.17984642662799629787.stgit@frogsfrogsfrogs> <177249785472.483405.1160086113668716052.stgit@frogsfrogsfrogs> <20260303164901.GJ57948@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 03, 2026 at 08:53:12AM -0800, Christoph Hellwig wrote: > On Tue, Mar 03, 2026 at 08:49:01AM -0800, Darrick J. Wong wrote: > > > > +ext4) > > > > + # added at the same time as uevents > > > > + modprobe fs-$FSTYP > > > > + test -e /sys/fs/ext4/features/uevents || \ > > > > + _notrun "$FSTYP does not support fsnotify ioerrors" > > > > + ;; > > > > +*) > > > > + _notrun "$FSTYP does not support fsnotify ioerrors" > > > > + ;; > > > > +esac > > > > > > Please abstract this out into a documented helper in common/ > > > > Ok. I'm not sure how to check for feature support on ext4 anymore since > > the uevents patch didn't get merged, and then I clearly forgot to rip > > that out of this helper here. > > Oh. Well, drop that then and move the xfs side and the default n > into a common helper instead of hardcoding it in the test. /me discovers that Baolin Liu added a "err_report_sec" sysfs knob to ext4 in 7.0-rc1, so I can just change the helper to look for that. I'll move the logic to common/rc. > > > and add proper error injection to the block code, which has been > > > somewhere on my todo list forever because dm-error and friends are > > > so painful to setup. Maybe I need to expedite that. > > > > I think it's theoretically possible to figure out that there's a zone > > size and then round outwards the error-target part of the dm table to > > align with a zone. > > It's the sysfs chunk size. btrfs/237 harcodes reading that out, > which could be easily lifted into a helper. > > > I have a lot more doubts about whether or not doing > > that in bash/awk is a good idea though. It'd be a lot easier if either > > the block layer did error injection or if someone just fixes those > > limitations in dm itself. > > I'll sign up to do the block layer stuff. Doing so should allow us > to run a lot more of the error injetion tests on zoned xfs, which > would be good. So I guess you should keep it as-is for now, > and I'll do a sweep later. Ok, thanks. :) --D