From: David Disseldorp <ddiss@suse.de>
To: fstests@vger.kernel.org
Cc: Dave Chinner <david@fromorbit.com>, David Disseldorp <ddiss@suse.de>
Subject: [PATCH] common/rc: add default _udev_wait timeout
Date: Thu, 19 Mar 2026 11:51:54 +1100 [thread overview]
Message-ID: <20260319005154.29274-1-ddiss@suse.de> (raw)
If udevd isn't running then "udevadm wait" loops endlessly. With a
--timeout parameter provided, udevadm (udev-254.27) prints to stderr:
Timed out for waiting devices being initialized.
The error message causes test failure via golden output mismatch and
is easier to debug than an infinite loop.
The timeout parameter is also compatible with existing
args="--removed <dev>" callers.
Signed-off-by: David Disseldorp <ddiss@suse.de>
---
common/rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index fd4ca964..aade0e5b 100644
--- a/common/rc
+++ b/common/rc
@@ -5544,7 +5544,7 @@ _udev_wait()
if [ -z "$UDEV_WAIT_PROG" ]; then
$UDEV_SETTLE_PROG >/dev/null 2>&1
else
- $UDEV_WAIT_PROG $args
+ $UDEV_WAIT_PROG --timeout 10 $args
fi
}
--
2.51.0
next reply other threads:[~2026-03-19 0:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 0:51 David Disseldorp [this message]
2026-03-19 15:38 ` [PATCH] common/rc: add default _udev_wait timeout Darrick J. Wong
2026-03-19 23:37 ` David Disseldorp
2026-03-20 14:44 ` Darrick J. Wong
2026-03-23 1:54 ` David Disseldorp
2026-03-23 2:03 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319005154.29274-1-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox