public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] common/rc: add default _udev_wait timeout
@ 2026-03-23  4:45 David Disseldorp
  0 siblings, 0 replies; only message in thread
From: David Disseldorp @ 2026-03-23  4:45 UTC (permalink / raw)
  To: fstests; +Cc: Dave Chinner, David Disseldorp

If udevd isn't running then "udevadm wait" loops endlessly. With a
--timeout parameter provided, udevadm (udev-254.27) prints to stderr:
  Timed out for waiting devices being initialized.

The error message causes test failure via golden output mismatch and
is easier to debug than an infinite loop.

The timeout parameter is also compatible with existing
args="--removed <dev>" callers. 60 seconds is relatively arbitrary, but
should be long enough to avoid premature timeout on regular systems.

Signed-off-by: David Disseldorp <ddiss@suse.de>
---
Changes since v1:
- increase timeout from 10 to 60 seconds

 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/rc b/common/rc
index fd4ca964..a490893f 100644
--- a/common/rc
+++ b/common/rc
@@ -5544,7 +5544,7 @@ _udev_wait()
 	if [ -z "$UDEV_WAIT_PROG" ]; then
 		$UDEV_SETTLE_PROG >/dev/null 2>&1
 	else
-		$UDEV_WAIT_PROG $args
+		$UDEV_WAIT_PROG --timeout 60 $args
 	fi
 }
 
-- 
2.51.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-03-23  5:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-23  4:45 [PATCH v2] common/rc: add default _udev_wait timeout David Disseldorp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox