public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: Zorro Lang <zlang@redhat.com>,
	fstests@vger.kernel.org,
	Super User <root@ltcrain119-lp6.ltc.tadn.ibm.com>,
	Disha Goel <disgoel@linux.ibm.com>
Subject: Re: [PATCH 3/4] generic/765: Ignore mkfs warning
Date: Wed, 1 Apr 2026 07:30:18 -0700	[thread overview]
Message-ID: <20260401143018.GH6212@frogsfrogsfrogs> (raw)
In-Reply-To: <1418f57e6115c93278a3891f075338163e2ec667.1775039135.git.ojaswin@linux.ibm.com>

On Wed, Apr 01, 2026 at 04:10:49PM +0530, Ojaswin Mujoo wrote:
> From: Super User <root@ltcrain119-lp6.ltc.tadn.ibm.com>

Who?

> This test validates atomic writes for all possible block sizes. In ext4, for
> smaller block sizes with configurations like:
> 
> export MKFS_OPTIONS="-O bigalloc,quota -b 65536 -C 131072"
> 
> The output can get corrupted with warnings like below because clustersize
> more than 16xbs is experimental:
> 
> + 16 times the block size is considered experimental

Er... a message that doesn't fail the mkfs is printed to stderr?
Maybe mke2fs should fix that...

> Hence pipe these to seqres.full to avoid false negatives.
> 
> Reported-by: Disha Goel <disgoel@linux.ibm.com>
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
> ---
>  tests/generic/765 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/765 b/tests/generic/765
> index 4c768783..6794eb72 100755
> --- a/tests/generic/765
> +++ b/tests/generic/765
> @@ -64,7 +64,7 @@ test_atomic_writes()
>      local bsize=$1
>  
>      get_mkfs_opts $bsize
> -    _scratch_mkfs $mkfs_opts >> $seqres.full
> +    _scratch_mkfs $mkfs_opts >> $seqres.full 2>&1

I think we still want to check that the format succeeded as a
precondition for the test round, right?

	_scratch_mkfs $mkfs_opts &>> $seqres.full || \
		echo "mkfs $mkfs_opts" failed"

--D

>      _scratch_mount
>  
>      test "$FSTYP" = "xfs" && _xfs_force_bdev data $SCRATCH_MNT
> -- 
> 2.53.0
> 
> 

  reply	other threads:[~2026-04-01 14:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01 10:40 [PATCH 1/4] ext4/061,062: Minor fixes and refactoring Ojaswin Mujoo
2026-04-01 10:40 ` [PATCH 2/4] generic/765: Fix sysfs path for nvme partitions Ojaswin Mujoo
2026-04-01 14:08   ` Darrick J. Wong
2026-04-05 15:07     ` Ojaswin Mujoo
2026-04-06 15:43       ` Darrick J. Wong
2026-04-07 14:48         ` Ojaswin Mujoo
2026-04-01 10:40 ` [PATCH 3/4] generic/765: Ignore mkfs warning Ojaswin Mujoo
2026-04-01 14:30   ` Darrick J. Wong [this message]
2026-04-05 14:10     ` Ojaswin Mujoo
2026-04-01 10:40 ` [PATCH 4/4] generic/775: Fix an infinite loop due to variable name clash Ojaswin Mujoo
2026-04-01 14:32   ` Darrick J. Wong
2026-04-05 14:07     ` Ojaswin Mujoo
2026-04-06 15:39       ` Darrick J. Wong
2026-04-01 14:33 ` [PATCH 1/4] ext4/061,062: Minor fixes and refactoring Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401143018.GH6212@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=disgoel@linux.ibm.com \
    --cc=fstests@vger.kernel.org \
    --cc=ojaswin@linux.ibm.com \
    --cc=root@ltcrain119-lp6.ltc.tadn.ibm.com \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox