FS/XFS testing framework
 help / color / mirror / Atom feed
From: "Theodore Tso" <tytso@mit.edu>
To: Artem Blagodarenko <artem.blagodarenko@gmail.com>
Cc: fstests@vger.kernel.org, adilger.kernel@dilger.ca
Subject: Re: [PATCH 2/2] ext4/065 encryption + casefold + dirdata feature combination
Date: Sat, 9 May 2026 13:42:42 -0400	[thread overview]
Message-ID: <20260509174242.GA51497@macsyma-wired.lan> (raw)
In-Reply-To: <20260419185209.4526-2-ablagodarenko@ddn.com>

On Sun, Apr 19, 2026 at 02:52:09PM -0400, Artem Blagodarenko wrote:
> From: Artem Blagodarenko <artem.blagodarenko@gmail.com>
> 
> Test ext4 encryption + casefold + dirdata feature combination.
> This test verifies that files created in directories with encryption,
> case-insensitive (casefold), and dirdata attributes work correctly.
> See ext4/064 for the same test WITHOUT dirdata feature.
> 
> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@gmail.com>

Note that the dirdata feature patches have not landed, and I've
expressed concerns of this patch set[1].

[1] https://lore.kernel.org/all/20260418214359.GA58909@macsyma-wired.lan/

From manual code inspection, the dirdata patch was never changing how
the data was stored.  So before we land the xfstests changes, could
you please add support in debugfs to set and get the dirdata stored
for a directory entry, and then change the test to actually _validate_
that when enabling encryption + casefold + dirdata, that the encrypted
hash is stored as a dirdata attribute?

Thanks,

					- Ted

  reply	other threads:[~2026-05-09 17:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-19 18:52 [PATCH 1/2] ext4/064 encryption + casefold feature combination WITHOUT dirdata Artem Blagodarenko
2026-04-19 18:52 ` [PATCH 2/2] ext4/065 encryption + casefold + dirdata feature combination Artem Blagodarenko
2026-05-09 17:42   ` Theodore Tso [this message]
2026-05-09 17:05 ` [PATCH 1/2] ext4/064 encryption + casefold feature combination WITHOUT dirdata Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260509174242.GA51497@macsyma-wired.lan \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=artem.blagodarenko@gmail.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox