FS/XFS testing framework
 help / color / mirror / Atom feed
From: Jan Prusakowski <jprusakowski@google.com>
To: Zorro Lang <zlang@kernel.org>, Chao Yu <chao@kernel.org>,
	fstests@vger.kernel.org
Cc: Ojaswin Mujoo <ojaswin@linux.ibm.com>, Qu Wenruo <wqu@suse.com>,
	 "Darrick J . Wong" <djwong@kernel.org>,
	Nirjhar Roy <nirjhar.roy.lists@gmail.com>,
	 Jan Prusakowski <jprusakowski@google.com>
Subject: [PATCH] generic/563: allow read tolerance for f2fs in scenario 3
Date: Fri, 15 May 2026 08:26:08 +0000	[thread overview]
Message-ID: <20260515082608.449455-1-jprusakowski@google.com> (raw)

F2FS is a log-structured file system that allocates new blocks even for
overwrites. To perform allocation, it may need to read metadata blocks
(such as the Node Address Table (NAT) or Segment Info Table (SIT)) if
they are not already in memory.

In scenario 3 (read -> read/write), unlike scenario 2, there is no prior
write in the same mount session to load these metadata blocks into memory.
Therefore, the write operation in the second cgroup triggers metadata
reads, which are charged to that cgroup.

Relax the read tolerance for f2fs in scenario 3 to accommodate these
expected metadata reads, matching the tolerance already used in scenario 2.

Signed-off-by: Jan Prusakowski <jprusakowski@google.com>
---
 tests/generic/563 | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/generic/563 b/tests/generic/563
index c3705c2f..f95eb073 100755
--- a/tests/generic/563
+++ b/tests/generic/563
@@ -151,7 +151,10 @@ $XFS_IO_PROG -c "pread 0 $iosize" -c "pwrite -b $blksize 0 $iosize" $SCRATCH_MNT
 switch_cg $cgdir
 $XFS_IO_PROG -c fsync $SCRATCH_MNT/file
 check_cg $cgdir/$seq-cg $iosize $iosize 5% 5%
-check_cg $cgdir/$seq-cg-2 0 0 0 0
+# F2FS may perform metadata reads during write in this scenario
+read_tol=0
+[ "$FSTYP" = "f2fs" ] && read_tol=33792
+check_cg $cgdir/$seq-cg-2 0 0 $read_tol 0
 
 if [ "$drop_io_cgroup" = 1 ]; then
 	echo "-io" > $cgdir/cgroup.subtree_control || _fail "subtree control"
-- 
2.54.0.563.g4f69b47b94-goog


                 reply	other threads:[~2026-05-15  8:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260515082608.449455-1-jprusakowski@google.com \
    --to=jprusakowski@google.com \
    --cc=chao@kernel.org \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=nirjhar.roy.lists@gmail.com \
    --cc=ojaswin@linux.ibm.com \
    --cc=wqu@suse.com \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox