From: Zorro Lang <zlang@kernel.org>
To: fstests@vger.kernel.org
Subject: [PATCH 1/2] tools/mvtest: align the output format between new and mvtest
Date: Wed, 20 May 2026 15:49:51 +0800 [thread overview]
Message-ID: <20260520074954.1877984-2-zlang@kernel.org> (raw)
In-Reply-To: <20260520074954.1877984-1-zlang@kernel.org>
Maintainers frequently rely on mvtest to manage new cases. Therefore,
./new and ./mvtest should have a consistent output format during case
creation and transfer. Otherwise, it can lead to maintenance issues,
such as regex failures failing to update the case numbers properly.
About 10 years ago, 03c633bff6e4 ("build: Allow alphanumeric test
name suffixes") made below change in new script:
-# FS QA Test No. $id
+# FS QA Test $id
However, the mvtest script still uses the "# FS QA Test No. ${did}".
Although we've fixed the regex mismatch issue, unify the output
format across both scripts will prevent future maintenance issues.
Signed-off-by: Zorro Lang <zlang@kernel.org>
---
tools/mvtest | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/mvtest b/tools/mvtest
index 09a9982b..0541d237 100755
--- a/tools/mvtest
+++ b/tools/mvtest
@@ -36,7 +36,7 @@ git mv "tests/${src}" "tests/${dest}"
git mv "tests/${src}.out" "tests/${dest}.out"
# make sure testcase is executable
chmod a+x "tests/${dest}"
-sed -e "s/^# FS[[:space:]]*QA.*Test.*[0-9]\+$/# FS QA Test No. ${did}/g" -i "tests/${dest}"
+sed -e "s/^# FS[[:space:]]*QA.*Test.*[0-9]\+$/# FS QA Test ${did}/g" -i "tests/${dest}"
sed -e "s/^QA output created by ${sid}$/QA output created by ${did}/g" -i "tests/${dest}.out"
sed -e "s/test-${sid}/test-${did}/g" -i "tests/${dest}.out"
--
2.54.0
next prev parent reply other threads:[~2026-05-20 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 7:49 [PATCH 0/2] align the "# FS QA Test" format Zorro Lang
2026-05-20 7:49 ` Zorro Lang [this message]
2026-05-20 7:49 ` [PATCH 2/2] tests: unify "FS QA Test" comment format Zorro Lang
2026-05-20 8:20 ` [PATCH 0/2] align the "# FS QA Test" format Christoph Hellwig
2026-05-20 9:59 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520074954.1877984-2-zlang@kernel.org \
--to=zlang@kernel.org \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox