From: Qu Wenruo <wqu@suse.com>
To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [PATCH] fstests: btrfs/138: add requirement for datacsum
Date: Mon, 8 Jun 2026 09:08:01 +0930 [thread overview]
Message-ID: <20260607233801.18453-1-wqu@suse.com> (raw)
[FALSE ALERT]
If one has specified "-o nodatasum" as mount options, the test case
btrfs/138 will fail with the following error:
MOUNT_OPTIONS -- -o nodatasum /dev/mapper/test-scratch1 /mnt/scratch
btrfs/138 34s ... - output mismatch (see /home/adam/xfstests/results//btrfs/138.out.bad)
--- tests/btrfs/138.out 2022-05-11 11:25:30.743333331 +0930
+++ /home/adam/xfstests/results//btrfs/138.out.bad 2026-06-08 09:04:30.627143086 +0930
@@ -1,2 +1,5 @@
QA output created by 138
+ERROR: failed to set compression for /mnt/scratch/zlib: Invalid argument
+ERROR: failed to set compression for /mnt/scratch/lzo: Invalid argument
+ERROR: failed to set compression for /mnt/scratch/zstd: Invalid argument
Silence is golden
...
[CAUSE]
Btrfs compression requires both datacow and datasum, thus nodatasum
mount option will reject compression completely, causing the above
failures.
[FIX]
Add _require_btrfs_no_nodatasum for the test case, so that for nodatasum
mount option the test case can be properly skipped other than causing
false failure.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
tests/btrfs/138 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/btrfs/138 b/tests/btrfs/138
index 17bbe28e..57ab1bd3 100755
--- a/tests/btrfs/138
+++ b/tests/btrfs/138
@@ -15,6 +15,7 @@ _begin_fstest auto compress
_require_scratch
_require_btrfs_command property
_require_btrfs_no_nodatacow
+_require_btrfs_no_nodatasum
algos=($(_btrfs_compression_algos))
--
2.51.2
next reply other threads:[~2026-06-07 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-07 23:38 Qu Wenruo [this message]
2026-06-08 6:48 ` [PATCH] fstests: btrfs/138: add requirement for datacsum Anand Suveer Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260607233801.18453-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox