From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 1/2] common: add a _require_external_realtime_device helper
Date: Tue, 9 Jun 2026 10:00:43 +0200 [thread overview]
Message-ID: <20260609080051.1712103-2-hch@lst.de> (raw)
In-Reply-To: <20260609080051.1712103-1-hch@lst.de>
Factor out the check for an RT device on an external section.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
common/rc | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/common/rc b/common/rc
index 71d872881610..336441c7a522 100644
--- a/common/rc
+++ b/common/rc
@@ -2405,6 +2405,17 @@ _require_no_large_scratch_dev()
_notrun "Large filesystem testing in progress, skipped this test"
}
+# require an external realtime device (excludes the internal RT device)
+_require_external_realtime_device()
+{
+ if [ "$USE_EXTERNAL" != "yes" ]; then
+ _notrun "External volumes not in use, skipped this test"
+ fi
+ if [ "$SCRATCH_RTDEV" = "" ]; then
+ _notrun "Realtime device required, skipped this test"
+ fi
+}
+
# this test requires that a realtime subvolume is in use, and
# that the kernel supports realtime as well.
#
@@ -2412,12 +2423,7 @@ _require_realtime()
{
local zone_type=`_zone_type $SCRATCH_DEV`
if [ "${zone_type}" = "none" ]; then
- if [ "$USE_EXTERNAL" != "yes" ]; then
- _notrun "External volumes not in use, skipped this test"
- fi
- if [ "$SCRATCH_RTDEV" = "" ]; then
- _notrun "Realtime device required, skipped this test"
- fi
+ _require_external_realtime_device
fi
}
--
2.53.0
next prev parent reply other threads:[~2026-06-09 8:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 8:00 add another RT growfs test Christoph Hellwig
2026-06-09 8:00 ` Christoph Hellwig [this message]
2026-06-09 14:39 ` [PATCH 1/2] common: add a _require_external_realtime_device helper Darrick J. Wong
2026-06-10 6:34 ` Hans Holmberg
2026-06-09 8:00 ` [PATCH 2/2] xfs: test that a grown RT section can be filled Christoph Hellwig
2026-06-09 14:40 ` Darrick J. Wong
2026-06-10 6:42 ` Hans Holmberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609080051.1712103-2-hch@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox