From: lan@suse.com
To: fstests@vger.kernel.org
Cc: An Long <lan@suse.com>
Subject: [PATCH] common/rc: fix mount options quoting in _mount
Date: Mon, 29 Jun 2026 21:29:35 +0800 [thread overview]
Message-ID: <20260629132935.30559-1-lan@suse.com> (raw)
From: An Long <lan@suse.com>
In commit 078f320 ("treewide: convert all $MOUNT_PROG to _mount"),
direct calls to $MOUNT_PROG were converted to call the helper function
_mount.
However, the _mount helper was implemented using `$*` instead of `"$@"`.
This unquoted argument expansion triggers word splitting on any arguments
containing spaces (such as the overlay mount options containing spaces in
tests `overlay/083` and `overlay/086`), causing the mount to fail with
"mount: bad usage".
Fix this regression by using `"$@"` in the _mount helper, which correctly
preserves argument boundaries exactly as they were provided by the caller.
---
common/rc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/rc b/common/rc
index 79189e7e..56dbea6f 100644
--- a/common/rc
+++ b/common/rc
@@ -296,10 +296,10 @@ _has_dmesg_since_option()
_mount()
{
- $MOUNT_PROG $*
+ $MOUNT_PROG "$@"
ret=$?
if [ "$ret" -ne 0 ]; then
- echo "\"$MOUNT_PROG $*\" failed at $(date)" >> "$seqres.mountfail?"
+ echo "\"$MOUNT_PROG $@\" failed at $(date)" >> "$seqres.mountfail?"
if _has_dmesg_since_option; then
dmesg --since '30s ago' >> "$seqres.mountfail?"
else
--
2.51.0
next reply other threads:[~2026-06-29 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 13:29 lan [this message]
2026-06-29 15:58 ` [PATCH] common/rc: fix mount options quoting in _mount Darrick J. Wong
2026-07-01 6:14 ` [PATCH v2] " lan
2026-07-01 16:34 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629132935.30559-1-lan@suse.com \
--to=lan@suse.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox