From: Qu Wenruo <wqu@suse.com>
To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Cc: bfoster@redhat.com, Anand Jain <asj@kernel.org>,
Filipe Manana <fdmanana@suse.com>
Subject: [PATCH] fstests: generic: add a basic cachestat test case
Date: Thu, 16 Jul 2026 08:07:16 +0930 [thread overview]
Message-ID: <20260715223716.5965-1-wqu@suse.com> (raw)
The test case is inspired by LTP, where there is a regression on 64K
page size systems with btrfs, that after a fsync, cachestat() still
report dirty pages.
The test case itself is pretty simple, fill the file with a buffered write that is
1/2/4/8/16 page sized, call cachestat() to make sure the cached/dirtied
number match the page number.
Then do a fsync(), and make sure the dirty page number reduced to 0
meanwhile cached is still the same.
Link: https://bugzilla.suse.com/show_bug.cgi?id=1270397
Reviewed-by: Anand Jain <asj@kernel.org>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
Changelog:
v3:
- Use golden output to greatly simplify the test case
- Do not mkfs for each size, just remove the original file
v2:
- Reject "sync" and "dax" mount options
Those mount options write back data synchronously, will screw up the
buffered write dirtied page reporting.
- Use AWK_PROG everywhere.
- Remove the unnecessary redirection for fsync
---
tests/generic/798 | 39 +++++++++++++++++++++++++++++++++++++++
tests/generic/798.out | 16 ++++++++++++++++
2 files changed, 55 insertions(+)
create mode 100755 tests/generic/798
create mode 100644 tests/generic/798.out
diff --git a/tests/generic/798 b/tests/generic/798
new file mode 100755
index 00000000..0fe37646
--- /dev/null
+++ b/tests/generic/798
@@ -0,0 +1,39 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2026 SUSE S.A. All Rights Reserved.
+#
+# FS QA Test 798
+#
+# Basic tests for cachestat()
+#
+. ./common/preamble
+_begin_fstest auto quick
+
+_require_xfs_io_command "cachestat"
+_require_scratch
+# Any mount option that writes data back synchronously should be rejected.
+# Or it will screw up the dirtied page reporting for buffered writes.
+_exclude_scratch_mount_option "dax"
+_exclude_scratch_mount_option "sync"
+
+pagesize=$(_get_page_size)
+
+_scratch_mkfs > /dev/null
+_scratch_mount
+
+for num_page in 1 2 4 8 16; do
+ size=$(($pagesize * $num_page))
+
+ echo "=== Test with $num_page pages ==="
+
+ rm -f $SCRATCH_MNT/foobar
+ $XFS_IO_PROG -f -c "pwrite -b $pagesize 0 $size" $SCRATCH_MNT/foobar > /dev/null
+ # Basic cached number reporting
+ $XFS_IO_PROG -c "cachestat 0 $size" $SCRATCH_MNT/foobar
+
+ # Test dirty page number reporting after a fsync.
+ $XFS_IO_PROG -c "fsync" -c "cachestat 0 $size" $SCRATCH_MNT/foobar
+done
+
+_scratch_unmount
+_exit 0
diff --git a/tests/generic/798.out b/tests/generic/798.out
new file mode 100644
index 00000000..ca6ead3c
--- /dev/null
+++ b/tests/generic/798.out
@@ -0,0 +1,16 @@
+QA output created by 798
+=== Test with 1 pages ===
+Cached: 1, Dirty: 1, Writeback: 0, Evicted: 0, Recently Evicted: 0
+Cached: 1, Dirty: 0, Writeback: 0, Evicted: 0, Recently Evicted: 0
+=== Test with 2 pages ===
+Cached: 2, Dirty: 2, Writeback: 0, Evicted: 0, Recently Evicted: 0
+Cached: 2, Dirty: 0, Writeback: 0, Evicted: 0, Recently Evicted: 0
+=== Test with 4 pages ===
+Cached: 4, Dirty: 4, Writeback: 0, Evicted: 0, Recently Evicted: 0
+Cached: 4, Dirty: 0, Writeback: 0, Evicted: 0, Recently Evicted: 0
+=== Test with 8 pages ===
+Cached: 8, Dirty: 8, Writeback: 0, Evicted: 0, Recently Evicted: 0
+Cached: 8, Dirty: 0, Writeback: 0, Evicted: 0, Recently Evicted: 0
+=== Test with 16 pages ===
+Cached: 16, Dirty: 16, Writeback: 0, Evicted: 0, Recently Evicted: 0
+Cached: 16, Dirty: 0, Writeback: 0, Evicted: 0, Recently Evicted: 0
--
2.51.2
next reply other threads:[~2026-07-15 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 22:37 Qu Wenruo [this message]
2026-07-16 10:05 ` [PATCH] fstests: generic: add a basic cachestat test case Brian Foster
-- strict thread matches above, loose matches on Subject: below --
2026-07-07 0:18 Qu Wenruo
2026-07-07 11:09 ` Anand Suveer Jain
2026-07-07 11:17 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715223716.5965-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=asj@kernel.org \
--cc=bfoster@redhat.com \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox