Re: [PATCH 00/12] fstests: introduce fscrypt support for btrfs

[Eric Biggers <ebiggers@kernel.org>]

On Tue, Jul 28, 2026 at 07:44:37AM +0200, Daniel Vacek wrote:
> On Tue, 28 Jul 2026 at 05:19, Christoph Hellwig <hch@infradead.org> wrote:
> > On Fri, Jul 24, 2026 at 03:33:16PM +0200, Daniel Vacek wrote:
> > > This is a rebase and cleanup of older patches [0] from Sweet Tea and Josef
> > > fixed to work with the recent kernel and btrfs-progs changes.
> >
> > I'm not sure if you post this just for reference or what the intent here
> > is, especially with a cover letter like this that doesn't have much
> > information.
> >
> > Before we doing anything for the btrfs-specific fscrypt changes in
> > xfstests, those changes should be accepted upstream first.
> >
> > Maybe some thing like splitting tests might make sense without that,
> > but then it should be posted separately.
> 
> Hi Christoph. Thanks for looking into this.
> 
> Yeah, I could have been more verbose, perhaps also using an RFC tag. I
> wanted to get feedback and a review from a wider audience to see if
> this is a viable direction. This is currently the base for my btrfs
> fscrypt development testing.
> Especially for upstream fscrypt changes, when sending those patches I
> was asked about tests support. I understand to keep fstests OOT as
> long as the kernel part is in development. But at the same time I'd
> like to make fstests complement the kernel part and ensure they are
> ready and available for everyone throughout the process. Kinda to
> "bundle" them all the next iteration.
> 
> Would you suggest otherwise?

Please keep sending out the tests along with the kernel patches.  But
yes, they aren't for immediate merging and should be tagged with RFC,
and the cover letter should mention that the kernel patches are pending.
Thanks!

- Eric