From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests <fstests@vger.kernel.org>, xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs/030: skip this test if metadir gets enabled anyway
Date: Wed, 26 Aug 2026 11:30:26 -0700 [thread overview]
Message-ID: <20260826183026.GW839663@frogsfrogsfrogs> (raw)
From: Darrick J. Wong <djwong@kernel.org>
This test requires metadir not to be enabled, but under certain
circumstances (aka _scratch_mkfs_xfs trying to be helpful and dropping
MKFS_OPTIONS) it can get enabled anyway if mkfs.xfs defaults to enabling
metadir. Check the fs feature set after formatting and skip the test if
metadir gets enabled.
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
tests/xfs/030 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/xfs/030 b/tests/xfs/030
index 22fbdb2fdbc999..d0b8f413bb9afd 100755
--- a/tests/xfs/030
+++ b/tests/xfs/030
@@ -72,6 +72,7 @@ else
_notrun "PQuota are enabled, test needs controlled sb recovery"
_scratch_unmount
fi
+_xfs_has_feature "$SCRATCH_DEV" metadir && _notrun "metadir enabled anyway"
clear=""
eval `_scratch_xfs_db -r -c "sb 1" -c stack | perl -ne '
if (/byte offset (\d+), length (\d+)/) {
next reply other threads:[~2026-08-26 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 18:30 Darrick J. Wong [this message]
2026-08-27 17:04 ` [PATCH] xfs/030: skip this test if metadir gets enabled anyway Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260826183026.GW839663@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox