From: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
To: fstests@vger.kernel.org
Cc: Prabhakar Pujeri <prabhakar.pujeri@dell.com>,
Zorro Lang <zlang@kernel.org>
Subject: [PATCH] generic/590,735: add missing _require_scratch check
Date: Mon, 31 Aug 2026 10:41:48 +0000 [thread overview]
Message-ID: <20260831104148.2243-1-prabhakar.pujeri@dell.com> (raw)
Both tests use the scratch device without first requiring one, so they
fail messily instead of skipping when no scratch device is configured.
Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
---
tests/generic/590 | 1 +
tests/generic/735 | 1 +
2 files changed, 2 insertions(+)
diff --git a/tests/generic/590 b/tests/generic/590
index 54c26f2..0775d6f 100755
--- a/tests/generic/590
+++ b/tests/generic/590
@@ -13,6 +13,7 @@ _begin_fstest auto prealloc preallocrw
. ./common/filter
+_require_scratch
_require_xfs_io_command "falloc"
maxextlen=$((0x1fffff))
diff --git a/tests/generic/735 b/tests/generic/735
index 60fa3dc..d7e732b 100755
--- a/tests/generic/735
+++ b/tests/generic/735
@@ -20,6 +20,7 @@ if [[ "$FSTYP" =~ ext[0-9]+ ]]; then
fi
_require_odirect
+_require_scratch
_require_xfs_io_command "falloc"
_require_xfs_io_command "finsert"
_require_max_file_range_blocks $(( (1 << 32) - 1 ))
--
2.55.0
next reply other threads:[~2026-08-31 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 10:41 Prabhakar Pujeri [this message]
2026-08-31 17:20 ` [PATCH] generic/590,735: add missing _require_scratch check Darrick J. Wong
2026-09-02 17:19 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831104148.2243-1-prabhakar.pujeri@dell.com \
--to=prabhakar.pujeri@dell.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox