Re: [RFC PATCH 1/2] common/nfs: add management helpers

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Sep 07, 2026 at 06:40:47PM +0200, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> This adds a few new helpers to manage local nfs client/servers. These
> can be used to exercise bugs which happens through a nfs share.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
>  common/nfs | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
> 
> diff --git a/common/nfs b/common/nfs
> index a03eaf48e1c0..4508a8a2e494 100644
> --- a/common/nfs
> +++ b/common/nfs
> @@ -33,3 +33,58 @@ _require_scratch_nfs_version()
>  	fi
>  	_scratch_unmount
>  }
> +
> +# Start rpcbind if it is not already running.
> +_start_rpcbind()
> +{
> +	rpcinfo -p localhost > /dev/null 2>&1 && return 0
> +	rpcbind 2>> $seqres.full || _notrun "Cannot start rpcbind"
> +	/usr/sbin/rpc.statd 2>> $seqres.full || _notrun "Cannot start rpc.statd"
> +	/usr/sbin/rpc.idmapd 2>> $seqres.full || _notrun "Cannot start rpc.idmapd"
> +	/usr/sbin/nfsdcld 2>> $seqres.full || _notrun "Cannot start nfsdcld"

Aren't these daemons usually configured as system services?

# service rpcbind start

etc?

> +}
> +
> +# Stop rpcbind.
> +_stop_rpcbind()
> +{
> +	pkill rpcbind 2>/dev/null
> +}
> +
> +# Start the NFS server if not already running.
> +_start_nfsd()
> +{
> +	rpcinfo -p localhost 2>/dev/null | grep -q nfs && return 0
> +	rpc.nfsd 2>> $seqres.full || _notrun "Cannot start rpc.nfsd"
> +	rpc.mountd 2>> $seqres.full || _notrun "Cannot start rpc.mountd"
> +}
> +
> +# Stop the NFS server.
> +_stop_nfsd()
> +{
> +	rpc.nfsd 0 2>/dev/null
> +	pkill rpc.mountd 2>/dev/null

If the system under test has nfs filesystems mounted, won't killing
those daemons also break the mounts?

I think that might break testing of nfs itself, and nfs-booted testing
nodes as well?

--D

> +}
> +
> +# Require a NFS server to be available and start rpcbind and nfsd if they are
> +# not already running.
> +_require_nfs_server()
> +{
> +	type -P exportfs > /dev/null 2>&1 || \
> +		_notrun "exportfs utility required, skipped this test"
> +	type -P rpc.nfsd > /dev/null 2>&1 || \
> +		_notrun "rpc.nfsd utility required, skipped this test"
> +	type -P rpc.mountd > /dev/null 2>&1 || \
> +		_notrun "rpc.mountd utility required, skipped this test"
> +	_start_rpcbind
> +	_start_nfsd
> +}
> +
> +# Require a NFS client to be available.
> +_require_nfs_client()
> +{
> +	grep -q nfs /proc/filesystems 2>/dev/null || \
> +		_notrun "Kernel does not support NFS client"
> +	type -P mount.nfs > /dev/null 2>&1 || \
> +		_notrun "mount.nfs utility required, skipped this test"
> +}
> -- 
> 2.55.0
> 
>