FS/XFS testing framework
 help / color / mirror / Atom feed
From: Andrey Albershteyn <aalbersh@kernel.org>
To: fstests@vger.kernel.org, zlang@kernel.org
Cc: Andrey Albershteyn <aalbersh@kernel.org>
Subject: [PATCH 4/4] xfstests: fix permissions on system file installed by libtoolize
Date: Fri, 18 Sep 2026 19:32:09 +0200	[thread overview]
Message-ID: <20260918173218.1254465-5-aalbersh@kernel.org> (raw)
In-Reply-To: <20260918173218.1254465-1-aalbersh@kernel.org>

Libtoolize installs set of auxiliary files from its system package.
Not all distributions have the same permissions set on these files.
For example, read-only libtoolize system package will copy those
files without write permissions. This causes build to fail as next
line copies ./include/install-sh over ./install-sh which will fail.

Fix this by setting permission explicitly on files copied by libtoolize.

See similar commit in xfsprogs:
6b32423addd2 ("xfsprogs: fix permissions on files installed by libtoolize")

Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile b/Makefile
index a48d8d62f038..6c3de609bf38 100644
--- a/Makefile
+++ b/Makefile
@@ -76,6 +76,9 @@ endif
 
 configure: configure.ac
 	libtoolize -cfi
+	chmod 755 config.guess config.sub install-sh
+	chmod 644 ltmain.sh m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 \
+		m4/ltversion.m4 m4/lt~obsolete.m4
 	cp include/install-sh .
 	aclocal -I m4
 	autoheader
-- 
2.54.0


  parent reply	other threads:[~2026-09-18 17:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18 17:32 [PATCH 0/4] xfstests: random fixes Andrey Albershteyn
2026-09-18 17:32 ` [PATCH 1/4] xfs/071: use _link_out_link instead of opencoding file picking Andrey Albershteyn
2026-09-22 12:37   ` Christoph Hellwig
2026-09-18 17:32 ` [PATCH 2/4] common: link .out file to the output directory Andrey Albershteyn
2026-09-22 12:38   ` Christoph Hellwig
2026-09-22 13:12     ` Andrey Albershteyn
2026-09-18 17:32 ` [PATCH 3/4] generic/452: make coping work with multi-call binary Andrey Albershteyn
2026-09-22 12:40   ` Christoph Hellwig
2026-09-18 17:32 ` Andrey Albershteyn [this message]
2026-09-22 12:40   ` [PATCH 4/4] xfstests: fix permissions on system file installed by libtoolize Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918173218.1254465-5-aalbersh@kernel.org \
    --to=aalbersh@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox