From: Christoph Hellwig <hch@lst.de>
To: Christoph Hellwig <hch@lst.de>,
moritz.tanner@linbit.com, fstests@vger.kernel.org
Subject: Re: [PATCH] generic/805: fix for external RT devices
Date: Fri, 25 Sep 2026 07:03:19 +0200 [thread overview]
Message-ID: <20260925050319.GA2408@lst.de> (raw)
In-Reply-To: <arUqzDhkxgvrhpa6@zlang-mailbox>
On Thu, Sep 24, 2026 at 09:56:53PM +0800, Zorro Lang wrote:
> On Thu, Sep 24, 2026 at 08:21:18AM +0200, Christoph Hellwig wrote:
> > use _mkfs_dev on the dm device instead of _scratch_mkfs_sized, otherwise
> > the file system could be created with an external RT device, and will
> > then fail to mount without it.
>
> This patch makes sense to me. But I was wondering if we should have a helper
> similar to _ignore_scratch_external_devices to allow a temporary device to
> act as SCRATCH_DEV, so it can use the _scratch_* helpers ?
You can't just ignore external devices, as options might also not apply
any more. We could add new helpers for just use scratch without
external devices, but IMHO there is no much benefit over just using the
_dev helpers.
next prev parent reply other threads:[~2026-09-25 5:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 6:21 [PATCH] generic/805: fix for external RT devices Christoph Hellwig
2026-09-24 13:56 ` Zorro Lang
2026-09-25 5:03 ` Christoph Hellwig [this message]
2026-09-28 9:50 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925050319.GA2408@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=moritz.tanner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox