Re: [PATCH v3 1/4] xfs/071: use _link_out_link instead of opencoding file picking

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Sep 25, 2026 at 12:45:09PM +0200, Andrey Albershteyn wrote:
> There's function which handles picking the right output file based on
> the .cfg.
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>

Looks ok,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  tests/xfs/071                             | 7 +++----
>  tests/xfs/071.cfg                         | 1 +
>  tests/xfs/{071.out.64 => 071.out.default} | 0
>  3 files changed, 4 insertions(+), 4 deletions(-)
>  create mode 100644 tests/xfs/071.cfg
>  rename tests/xfs/{071.out.64 => 071.out.default} (100%)
> 
> diff --git a/tests/xfs/071 b/tests/xfs/071
> index c4722f67181a..47874e505c01 100755
> --- a/tests/xfs/071
> +++ b/tests/xfs/071
> @@ -5,7 +5,6 @@
>  # FS QA Test No. 071
>  #
>  # Exercise IO at large file offsets.
> -seqfull=$0
>  . ./common/preamble
>  _begin_fstest rw auto
>  
> @@ -22,11 +21,11 @@ _cleanup()
>  
>  bitsperlong=`$here/src/feature -w`
>  # link correct .out file
> -rm -f $seqfull.out
> +seqfull=$0
>  if [ "$bitsperlong" -eq 32 ]; then
> -	ln -s $seq.out.32 $seqfull.out
> +	_link_out_file "32"
>  else
> -	ln -s $seq.out.64 $seqfull.out
> +	_link_out_file ""
>  fi
>  
>  _filter_io()
> diff --git a/tests/xfs/071.cfg b/tests/xfs/071.cfg
> new file mode 100644
> index 000000000000..e806b07bc08b
> --- /dev/null
> +++ b/tests/xfs/071.cfg
> @@ -0,0 +1 @@
> +32: 32
> diff --git a/tests/xfs/071.out.64 b/tests/xfs/071.out.default
> similarity index 100%
> rename from tests/xfs/071.out.64
> rename to tests/xfs/071.out.default
> -- 
> 2.54.0
> 
>