public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Mahoney <jeffm@suse.com>
To: Eryu Guan <guaneryu@gmail.com>, "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: fstests@vger.kernel.org, nborisov@suse.com, fdmanana@suse.com
Subject: Re: [PATCH] check: annotate good and expunged tests in results
Date: Tue, 1 May 2018 09:34:41 -0400	[thread overview]
Message-ID: <21a3f3ab-b439-9851-8258-4e3e7f9ca472@suse.com> (raw)
In-Reply-To: <33a80b8a-fe26-faee-9704-d1bb2c933a3a@suse.com>

On 4/30/18 4:48 PM, Jeff Mahoney wrote:
> On 4/27/18 10:45 PM, Eryu Guan wrote:
>> On Fri, Apr 27, 2018 at 05:00:09PM +0000, Luis R. Rodriguez wrote:
>>> On Fri, Apr 27, 2018 at 07:23:56PM +0800, Eryu Guan wrote:
>>>>
>>>> But the test run & pass info is already available from the check output
>>>> and the test result summary at the end of check. Is that sufficient for
>>>> you? Also, we already have mechanism to generate a test report in xunit
>>>> format, i.e. ./check -R xunit -g auto, which includes results for passed
>>>> & failed & notrun tests.
>>>
>>> Do we have a way to parse the results *after* a run? For instance,
>>> if you forgot -R xunit ?
>>
>> There's a tools/compare-failures script that takes the outputs of check
>> as inputs and compares the results. But, TBH, I never run it after
>> reviewing it.. Perhaps it could be enhanced somehow.
> 
> Yeah, that takes check output.  Without capturing it at runtime, it
> can't compare anything.
> 
> The XML report may do most of what I want provided we can enable it by
> default and write it someplace safe rather than clean it up
> automatically when the test run is interrupted.
> 
> I already have test code that extends it to output expunged tests and to
> add an explicit <pass/> element.  It saves the timestamps already, so
> that's a plus.

And shortly after writing this, I had a test run hang.  Since it hung,
even writing it on exit wouldn't have worked.  There's not enough
information leftover to generate it.  I think I'd still like the results
directory to contain the information required to generate it as a
post-mortem.

-Jeff

-- 
Jeff Mahoney
SUSE Labs

  reply	other threads:[~2018-05-01 13:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 21:38 [PATCH] check: annotate good and expunged tests in results jeffm
2018-04-24  9:36 ` Eryu Guan
2018-04-24 18:03   ` Jeff Mahoney
2018-04-27 11:23     ` Eryu Guan
2018-04-27 17:00       ` Luis R. Rodriguez
2018-04-28  2:45         ` Eryu Guan
2018-04-30 20:48           ` Jeff Mahoney
2018-05-01 13:34             ` Jeff Mahoney [this message]
2018-05-01 14:44               ` Jeff Mahoney
2019-02-12 17:04                 ` Luis Chamberlain
2019-02-14 14:13                   ` Jeff Mahoney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21a3f3ab-b439-9851-8258-4e3e7f9ca472@suse.com \
    --to=jeffm@suse.com \
    --cc=fdmanana@suse.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=mcgrof@kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox