From: Mikulas Patocka <mpatocka@redhat.com>
To: Eryu Guan <eguan@redhat.com>, Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org, Kent Overstreet <kent.overstreet@linux.dev>
Subject: [PATCH] generic/558: limit the number of spawned subprocesses
Date: Tue, 11 Jul 2023 17:51:42 +0200 (CEST) [thread overview]
Message-ID: <2bb7705c-9a1a-6185-4554-9121e5cda710@redhat.com> (raw)
When I run the test 558 on bcachefs, it works like a fork-bomb and kills
the machine. The reason is that the "while" loop spawns "create_file"
subprocesses faster than they are able to complete.
This patch fixes the crash by limiting the number of subprocesses to 128.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
---
tests/generic/558 | 1 +
1 file changed, 1 insertion(+)
Index: xfstests-dev/tests/generic/558
===================================================================
--- xfstests-dev.orig/tests/generic/558
+++ xfstests-dev/tests/generic/558
@@ -48,6 +48,7 @@ echo "Create $((loop * file_per_dir)) fi
while [ $i -lt $loop ]; do
create_file $SCRATCH_MNT/testdir $file_per_dir $i >>$seqres.full 2>&1 &
let i=$i+1
+ if [ $((i % 128)) = 0 ]; then wait; fi
done
wait
next reply other threads:[~2023-07-11 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 15:51 Mikulas Patocka [this message]
2023-07-11 23:44 ` [PATCH] generic/558: limit the number of spawned subprocesses Darrick J. Wong
2023-07-12 1:09 ` Kent Overstreet
2023-07-12 5:15 ` Amir Goldstein
2023-07-12 10:10 ` Mikulas Patocka
2023-07-12 14:52 ` Kent Overstreet
2023-07-12 17:59 ` Mikulas Patocka
2023-07-12 18:35 ` Kent Overstreet
2023-07-12 9:57 ` Mikulas Patocka
2023-07-12 22:05 ` Darrick J. Wong
2023-07-12 18:40 ` Zorro Lang
2023-07-13 1:44 ` Theodore Ts'o
2023-07-13 1:48 ` Darrick J. Wong
2023-07-13 15:08 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bb7705c-9a1a-6185-4554-9121e5cda710@redhat.com \
--to=mpatocka@redhat.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox