From: Anju T Sudhakar <anju@linux.vnet.ibm.com>
To: "Darrick J. Wong" <djwong@kernel.org>,
Christian Brauner <christian.brauner@ubuntu.com>,
Eryu Guan <guan@eryu.me>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] idmap: override btrfs_ioctl_vol_args_v2 if system header doesn't have subvolid
Date: Wed, 25 Aug 2021 11:46:27 +0530 [thread overview]
Message-ID: <35f0a5ad-fa17-d149-28a6-d16bcde0b4ec@linux.vnet.ibm.com> (raw)
In-Reply-To: <20210823182138.GF12612@magnolia>
On 8/23/21 11:51 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> The struct btrfs_ioctl_vol_args_v2 in /usr/include/linux/btrfs.h on my
> system predates the inclusion of the "subvolid" field. This causes the
> following build failure:
>
> idmapped-mounts.c: In function 'btrfs_delete_subvolume_id':
> idmapped-mounts.c:9730:6: error: 'struct btrfs_ioctl_vol_args_v2' has no member named 'subvolid'
> 9730 | args.subvolid = subvolid;
> | ^
>
> Since this source file contains its own more uptodate copy of that
> structure, add some more autoconf/cpp magic so that we can override the
> struct definition if the system header doesn't have the desired field.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
LGTM. Thanks for fixing this issue. I too hit this issue in my system and
this patch helped me.
Reviewed-by: Anju T Sudhakar<anju@linux.vnet.ibm.com>
prev parent reply other threads:[~2021-08-25 6:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 18:21 [PATCH] idmap: override btrfs_ioctl_vol_args_v2 if system header doesn't have subvolid Darrick J. Wong
2021-08-24 11:54 ` Christian Brauner
2021-08-24 13:11 ` Zorro Lang
2021-08-25 6:16 ` Anju T Sudhakar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35f0a5ad-fa17-d149-28a6-d16bcde0b4ec@linux.vnet.ibm.com \
--to=anju@linux.vnet.ibm.com \
--cc=christian.brauner@ubuntu.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox