From: Anand Jain <anajain.sg@gmail.com>
To: Christoph Hellwig <hch@infradead.org>, Anand Jain <asj@kernel.org>
Cc: zlang@kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: fix flaky device name in _cleanup_flakey
Date: Thu, 18 Dec 2025 14:11:22 +0800 [thread overview]
Message-ID: <3a3ce42a-6eee-464b-a8f4-ff7590ff9dea@gmail.com> (raw)
In-Reply-To: <aUORO1y4rkXHAH-f@infradead.org>
On 18/12/25 13:29, Christoph Hellwig wrote:
> On Thu, Dec 18, 2025 at 01:00:22AM +0800, Anand Jain wrote:
>> There is no device named flakey-test, which _cleanup_flakey() currently
>> uses. The actual device name is stored in $FLAKEY_NAME and is set to
>> flakey-test.$seq. Use $FLAKEY_NAME instead.
>
> This looks good, but I vaguely remember fixing this up on the go, and
> seeing random hangs. While that could have been me fat-fingering
> something, please run all the tests using this first to make sure it
> works just to be safe.
Yeah, I've already run the tests that fall under the
_require_dm_target flakey, and they have no regression
with this. I reran them again just now to be safe.
Happy to run any specific set/test case if you'd
like me to try.
next prev parent reply other threads:[~2025-12-18 6:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 17:00 [PATCH] fstests: fix flaky device name in _cleanup_flakey Anand Jain
2025-12-17 17:45 ` Darrick J. Wong
2025-12-18 5:29 ` Christoph Hellwig
2025-12-18 6:11 ` Anand Jain [this message]
2025-12-18 6:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a3ce42a-6eee-464b-a8f4-ff7590ff9dea@gmail.com \
--to=anajain.sg@gmail.com \
--cc=asj@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox