From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: "Darrick J. Wong" <djwong@kernel.org>,
"guaneryu@gmail.com" <guaneryu@gmail.com>,
"zlang@redhat.com" <zlang@redhat.com>
Cc: "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"guan@eryu.me" <guan@eryu.me>
Subject: Re: [PATCH 3/3] xfs/533: fix golden output for this test
Date: Thu, 4 Aug 2022 01:53:31 +0000 [thread overview]
Message-ID: <4094bf3b-9be0-c629-648a-b78999e3ec83@fujitsu.com> (raw)
In-Reply-To: <165950049724.198815.5496412458825635633.stgit@magnolia>
on 2022/08/03 12:21, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Not sure what's up with this new test, but the golden output isn't right
> for upstream xfsprogs for-next. Change it to pass there...
It failed becuase libxfs code validates v5 feature fields.
b12d5ae5d ("xfs: validate v5 feature fields")
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> tests/xfs/533.out | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/tests/xfs/533.out b/tests/xfs/533.out
> index 7deb78a3..439fb16e 100644
> --- a/tests/xfs/533.out
> +++ b/tests/xfs/533.out
> @@ -1,5 +1,5 @@
> QA output created by 533
> Allowing write of corrupted data with good CRC
> magicnum = 0
> -bad magic number
> +Superblock has bad magic number 0x0. Not an XFS filesystem?
Since this case is designed to detect xfs_db bug, should we filter the
output?
Best Regards
Yang Xu
> 0
>
next prev parent reply other threads:[~2022-08-04 1:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 4:21 [PATCHSET 0/3] fstests: random fixes for v2022.07.31 Darrick J. Wong
2022-08-03 4:21 ` [PATCH 1/3] xfs/432: fix this test when external devices are in use Darrick J. Wong
2022-08-04 15:55 ` Zorro Lang
2022-08-03 4:21 ` [PATCH 2/3] xfs/291: convert open-coded _scratch_xfs_repair usage Darrick J. Wong
2022-08-04 15:57 ` Zorro Lang
2022-08-03 4:21 ` [PATCH 3/3] xfs/533: fix golden output for this test Darrick J. Wong
2022-08-04 1:53 ` xuyang2018.jy [this message]
2022-08-04 5:06 ` Darrick J. Wong
2022-08-04 5:15 ` Darrick J. Wong
2022-08-04 5:31 ` xuyang2018.jy
2022-08-04 5:37 ` Darrick J. Wong
2022-08-04 16:26 ` [PATCH v1.1 3/3] xfs/533: fix false negatives " Darrick J. Wong
2022-08-05 1:38 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4094bf3b-9be0-c629-648a-b78999e3ec83@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox